Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT_Mu17_Photon30_IsoCaloId_v trigger filters backport to CMSSW_12_4_X #40034

Closed
wants to merge 880 commits into from

Conversation

mrcthiel
Copy link
Contributor

@mrcthiel mrcthiel commented Nov 9, 2022

Backporting changes as requested in #39929 (comment)

cmsbuild and others added 30 commits August 22, 2022 11:48
…ePCLHarverster_12_4_X

[12.4.X] Fix for `SiPixelLorentzAnglePCLHarvester` after cms-sw#39075
…ENanoRun3_forPR

[JMENanoAOD] Backport of cms-sw#39000 (Updates for Run-3) to 12_4_X
…alignment_12_4_X

[12_4_X] Run3 GEMGeometryBuilder Run3 modifier and fix DQM GEM chambers
Run3-alca228X Backport to 12_4_X the PR cms-sw#39116 which modifies IsolatedBunchSelector and HcalNoise AlCaReco
 - Improve the representation of trigger expression
   - Improved the dumped representation of trigger expressions:
     - AND, OR, and NOT operators add parentheses around their subexpression;
     - uninitialised Path and L1uGT readers use an explicit name instead of FALSE.

 - Print how the expressions are interpreted

 - Delimit tokens and operands
   - Require a delimiter after each token and operamd, to avoid en expression like:
     "NOTSomePath ANDOtherPath"
     to be parsed as:
     "NOT SomePath AND OtherPath"

 - Add more tests

 - Compare the parsed and expected representations
HcalDQM: Revert timing bit to old default, backport of cms-sw#39058
[12_4_X] Fix PPSDiamondDQM histogram of rechits in the last lumisection
[12_4_X] Fixed initialisation of diamond sensitive detector
…_124X

fix for `NOT` operator in `triggerExpression::Parser` [`12_4_X`]
…TriggerSummaryProducerAOD_124X

fix for process-name check in `TriggerSummaryProducerAOD` [`12_4_X`]
…asClient, update sequence run in alcareco production, update unit tests
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40034/32981

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2022

A new Pull Request was created by @mrcthiel for master.

It involves the following packages:

  • (externals)

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor

swertz commented Nov 10, 2022

@mrcthiel I'm afraid this PR is unmergeable, something must have gone wrong when backporting your commit.

@mrcthiel
Copy link
Contributor Author

I tried again

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40034/33044

@cmsbuild
Copy link
Contributor

Pull request #40034 was updated. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please check and sign again.

@swertz
Copy link
Contributor

swertz commented Nov 15, 2022

please close

@cmsbuild cmsbuild closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.