-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-alca228 Update for isolated bunch selector AlCaReco #39116
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39116/31655
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@mariadalfonso Just submitted the PR and I am requesting a back port PR as well |
@cmsbuild Please test |
…lNoise AlCaReco
HLTPaths = ['HLT_PFMET130'], | ||
# eventSetupPathsKey='HcalCalNoise', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not what we should do.... what we should do is the commented out line, i.e. have
eventSetupPathsKey='HcalCalNoise'
active.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -145,7 +143,7 @@ void AlCaIsolatedBunchSelector::fillDescriptions(edm::ConfigurationDescriptions& | |||
edm::ParameterSetDescription desc; | |||
desc.add<edm::InputTag>("triggerResultLabel", edm::InputTag("TriggerResults", "", "HLT")); | |||
desc.add<std::string>("processName", "HLT"); | |||
desc.add<std::string>("triggerName", "HLT_HcalIsolatedBunch"); | |||
desc.add<std::string>("triggerName", "HLT_ZeroBias_IsolatedBunches"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this trigger bit could be dropped here and use instead the alcarecotriggerbits key in here: https://github.com/cms-sw/cmssw/blob/master/Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalIsolatedBunchSelector_cff.py#L8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am now using only the trigger bits in the new commit
@cmsbuild , please abort |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39116/31671
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39116/31672
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa44c5/26945/summary.html Comparison SummarySummary:
|
test parameters:
|
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa44c5/26956/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
urgent
|
+1 |
Run3-alca228X Backport to 12_4_X the PR #39116 which modifies IsolatedBunchSelector and HcalNoise AlCaReco
PR description:
Update for isolated bunch selector AlCaReco
PR validation:
Useful for Reprocessing 2022 data
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be back ported to 12_4_X