Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-alca228 Update for isolated bunch selector AlCaReco #39116

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Aug 19, 2022

PR description:

Update for isolated bunch selector AlCaReco

PR validation:

Useful for Reprocessing 2022 data

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be back ported to 12_4_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39116/31655

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Calibration/HcalAlCaRecoProducers (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@mariadalfonso Just submitted the PR and I am requesting a back port PR as well

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

Comment on lines 6 to 7
HLTPaths = ['HLT_PFMET130'],
# eventSetupPathsKey='HcalCalNoise',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what we should do.... what we should do is the commented out line, i.e. have
eventSetupPathsKey='HcalCalNoise' active.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -145,7 +143,7 @@ void AlCaIsolatedBunchSelector::fillDescriptions(edm::ConfigurationDescriptions&
edm::ParameterSetDescription desc;
desc.add<edm::InputTag>("triggerResultLabel", edm::InputTag("TriggerResults", "", "HLT"));
desc.add<std::string>("processName", "HLT");
desc.add<std::string>("triggerName", "HLT_HcalIsolatedBunch");
desc.add<std::string>("triggerName", "HLT_ZeroBias_IsolatedBunches");
Copy link
Contributor

@malbouis malbouis Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this trigger bit could be dropped here and use instead the alcarecotriggerbits key in here: https://github.com/cms-sw/cmssw/blob/master/Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalIsolatedBunchSelector_cff.py#L8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am now using only the trigger bits in the new commit

@tvami
Copy link
Contributor

tvami commented Aug 19, 2022

@cmsbuild , please abort

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39116/31671

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39116/31672

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa44c5/26943/summary.html
COMMIT: 3ca06cf
CMSSW: CMSSW_12_5_X_2022-08-19-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39116/26943/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3693040
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3693000
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 1 / 50 workflows

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa44c5/26945/summary.html
COMMIT: 3ca06cf
CMSSW: CMSSW_12_5_X_2022-08-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39116/26945/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3693040
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3693012
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.008 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 1 / 50 workflows

@tvami
Copy link
Contributor

tvami commented Aug 20, 2022

test parameters:

  • workflows = 1001.3,1002.3

@tvami
Copy link
Contributor

tvami commented Aug 20, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa44c5/26956/summary.html
COMMIT: 3ca06cf
CMSSW: CMSSW_12_5_X_2022-08-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39116/26956/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fa44c5/1001.3_RunSingleMuon2022B+RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fa44c5/1002.3_RunZeroBias2022B+RunZeroBias2022B+TIER0PROMPTRUN3+ALCASPLITRUN3+ALCAHARVDEXPRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 3722788
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3722760
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.008 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 220 log files, 49 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 2 / 52 workflows

@tvami
Copy link
Contributor

tvami commented Aug 21, 2022

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Aug 21, 2022

urgent

  • backport affects data taking / rereco as well

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cf9c605 into cms-sw:master Aug 21, 2022
cmsbuild added a commit that referenced this pull request Aug 23, 2022
Run3-alca228X Backport to 12_4_X the PR #39116 which modifies IsolatedBunchSelector and HcalNoise AlCaReco
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants