-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update input of phase2_digi_reco_pixelntuple unit test #39123
Update input of phase2_digi_reco_pixelntuple unit test #39123
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39123/31678
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test with #38442,cms-data/L1Trigger-Phase2L1ParticleFlow#4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
@@ -19,7 +19,7 @@ | |||
process.load('Configuration.StandardSequences.DigiToRaw_cff') | |||
process.load('HLTrigger.Configuration.HLT_Fake2_cff') | |||
process.load('Configuration.StandardSequences.RawToDigi_cff') | |||
process.load('Configuration.StandardSequences.L1Reco_cff') | |||
#process.load('Configuration.StandardSequences.L1Reco_cff') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be removed for good, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. We already remove it from the main Phase-2 sequence.
Here is the issue we discussed,
#33012
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so instead of commenting can you delete the line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete.
SLHCUpgradeSimulations/Geometry/test/phase2_digi_reco_pixelntuple_cfg.py
Show resolved
Hide resolved
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39123/31679
|
Pull request #39123 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again. |
test parameters: |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39123/31732
|
Pull request #39123 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again. |
@cmsbuild please test |
Looks good @srimanob (unit test passed); you might want to update the title of the PR. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9264b/27021/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+Upgrade This is technical PR, to avoid unit test failure when L1 collection is dropped. The failure in comparison does not come from this PR. |
@civanch could you please re-sign. Thanks. |
+geometry |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR update the input of
SLHCUpgradeSimulations/Geometry/test/phase2_digi_reco_pixelntuple_cfg.py
from SingleMu GEN-SIM-RECO to GEN-SIM. This PR will avoid the unit failure when L1T PR (#38442) is merged due to removed collection.I use this chance also to remove obsolete L1Reco step from Phase2 sequence.
The PR test is trigger with #38442 to show that there will be no unit test failure anymore. However, this PR can be merged first (independent of #38442).
PR validation:
Run locally,
cmsRun phase2_digi_reco_pixelntuple_cfg.py
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, and no need of backport