-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_4_X] Fix PPSDiamondDQM histogram of rechits in the last lumisection #39077
Conversation
type bug-fix, ctpps |
A new Pull Request was created by @ChrisMisan (Christopher) for CMSSW_12_4_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #39076 |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-500b68/26852/summary.html Comparison SummarySummary:
|
@ChrisMisan do you need this deployed online? |
yes, it'd be good to have it online, also, we have another few corrections to this dqm coming in the next days. |
@emanueleusai kind reminder |
testing at P5 |
test completed and deployed at P5 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR fixes the the rechits plot which is suppose to represent the last lumisection. Before the fix plot was being filled with all the lumisections.
PR validation:
standard tests
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
backport of #39076