-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HcalDQM: Revert timing bit to old default, backport of #39058 #39057
Conversation
A new Pull Request was created by @lwang046 for CMSSW_12_4_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@lwang046 I suppose this is a backport and you're going to submit it also to master 12_5_X? |
Pull request #39057 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again. |
backport of #39058 |
please test |
-1 Failed Tests: RelVals RelVals-INPUT RelVals
RelVals-INPUT |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5f087/26895/summary.html Comparison SummarySummary:
|
testing at P5 |
tests completed and PR deployed at P5 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Corrects the uHTR&L1T HCAL TP mismatch discrepancy seen between L1 and HCAL subdetector. Now the finegrain bit definition in both are the same old default. Can be updated when the HCAL LLP trigger commissioning work completes.
Request to be integrated in the Online DQM Production release at P5.
PR validation:
runTheMatrix.py -l limited -i all --ibeos
test okay