Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlCaReco producers in phase-2 workflows #39858

Merged
merged 4 commits into from
Oct 28, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 26, 2022

PR description:

The goal of this PR is to start exercising Tracker alcareco producers in the phase-2 workflows, as there is interest in trying a preliminary alignment with the phase-2 geometry.
A minimal set of changes if proposed in order to achieve that goal, including the necessary update of the phase2_realistic autoCond key in order to get most updated trigger bits from the run-3 global tag (see also cmsTalk):

In addition the pseudo-rapidity range of the alignment alcarecos is modified in the case of the phase-2 tracker to allow full coverage (up to |η|<4).

PR validation:

Run successfully runTheMatrix.py -l 20834.0 -t 4 -j 8

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

cc:
@consuegs

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39858/32755

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)
  • Configuration/AlCa (alca)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • RecoTracker/TransientTrackingRecHit (reconstruction)

@malbouis, @ChrisMisan, @yuanchao, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @sunilUIET, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @kpedro88, @Martin-Grunewald, @tlampen, @trtomei, @slomeo, @pakhotin, @makortel, @JanFSchulte, @dgulhan, @missirol, @beaucero, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @mmusich, @mtosi, @fabiocos, @adewit, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 26, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64ceed/28531/summary.html
COMMIT: 941de35
CMSSW: CMSSW_12_6_X_2022-10-26-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39858/28531/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 13 differences found in the comparisons
  • Reco comparison had 1 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 2918374
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2918340
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 180 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@malbouis
Copy link
Contributor

Thank you for this, @mmusich !

I have created a versioned GT to replace the Candidate GT in autoCond.py: 125X_mcRun4_realistic_v3

The only difference wrt to the previous GT is the AlCaRecoTriggerBits tag: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun4_realistic_v2/125X_mcRun4_realistic_v3

Would you please replace the Candidate Gt with this versioned one?

@malbouis
Copy link
Contributor

+alca

  • I already leave the alca signature but I have no problem signing again in case the tests are re-triggered due to changes :-)
  • Changes are inline with the description
  • the tests results came back fine, only message logger failures

@mmusich mmusich force-pushed the ALCARECOProducersInPhase2 branch from 941de35 to 638de99 Compare October 27, 2022 07:42
@mandrenguyen
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

To clarify, the PR proposes to run ALCA step by default in all Phase-2 workflows. What is the cost, i.e. in terms of RelVals disk when we run full set of relvals, both NoPU and PU200?

I see we currently do the same for Run-3 also.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 27, 2022

PU200?

is not run.

@srimanob
Copy link
Contributor

Ah, OK. The Alca step is not in

upgradeProperties[2026][key+'PU']['ScenToRun'] = ['GenSimHLBeamSpot','DigiTriggerPU','RecoGlobalPU', 'HARVESTGlobalPU']

@srimanob
Copy link
Contributor

+Upgrade

@mmusich
Copy link
Contributor Author

mmusich commented Oct 28, 2022

@cms-sw/pdmv-l2 please have a look and if you agree sign.
Thank you.

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants