NANO configuration Cleanup

[vlimant]

PR description:

what we intend to put in this PR is a cleanup of the nano configuration:

• - drop support of old mini input (drop<=10.2.X)
• - include module validation through fillDescription
• - normalizing of modifiers syntax ( Allow chaining of Modifier toModify() and toReplaceWith() calls #39342 )

PR validation:

no change of output is expected

runTheMatrix.py --what nano --site "" --command "--number 10" is the standard candle.

cms-bot nano validation using cms-sw/cms-bot#1867 would be great.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39796/32666

• This PR adds an extra 80KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/muons_cff.py modified in PR(s): Adding MVA ID to nanoAOD code #39355
  • File PhysicsTools/NanoAOD/python/nanoDQM_cff.py modified in PR(s): Adding MVA ID to nanoAOD code #39355
  • File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
  • File PhysicsTools/NanoAOD/python/triggerObjects_cff.py modified in PR(s): Adding photon and muon leg trigger filters of HLT_Mu17_Photon30_IsoCa… #39309

[cmsbuild]

A new Pull Request was created by @vlimant (vlimant) for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39796/32667

• This PR adds an extra 88KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532
  • File PhysicsTools/NanoAOD/python/muons_cff.py modified in PR(s): Adding MVA ID to nanoAOD code #39355
  • File PhysicsTools/NanoAOD/python/nanoDQM_cff.py modified in PR(s): Adding MVA ID to nanoAOD code #39355
  • File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
  • File PhysicsTools/NanoAOD/python/triggerObjects_cff.py modified in PR(s): Adding photon and muon leg trigger filters of HLT_Mu17_Photon30_IsoCa… #39309

[cmsbuild]

Pull request #39796 was updated. @perrotta, @rappoccio, @swertz, @vlimant, @cmsbuild, @fabiocos, @davidlange6 can you please check and sign again.

[srimanob]

Hi @vlimant

Would you mind to provide a bit more information on the strategy of Nano dev? For example, I see that you drop
'run3_nanoAOD_devel' and keep only 'run3_nanoAOD_122', 'run3_nanoAOD_124'. What will happen when developers would like to merge new features to NANO? Which era that new features will stay with? Thanks.

[vlimant]

Hi @srimanob ,
new feature will go in master and developing release. modifier based integration is not a good way to do things IMO, and turned out to make maintenance unbearable. New nano version for wider usage (production or else) will be managed like the V10.

[srimanob]

+Upgrade

From upgrade related config, this PR clean up old config and change the strategy how to deal with dev in Nano.

[vlimant]

@cms-sw/reconstruction-l2 @cms-sw/pdmv-l2 I hope we can get a signature this week

[kskovpen]

+pdmv

[mandrenguyen]

+1

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[perrotta]

@vlimant since the merge of this PR there are several crashes in the nanoAOD workflows in the IB wit the message

Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw/CMSSW_12_6_X_2022-11-08-1100/bin/el8_amd64_gcc10/cmsDriver.py", line 51, in <module>
    run()
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw/CMSSW_12_6_X_2022-11-08-1100/bin/el8_amd64_gcc10/cmsDriver.py", line 28, in run
    configBuilder.prepare()
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/src/Configuration/Applications/python/ConfigBuilder.py", line 2325, in prepare
    self.pythonCfgCode += self.addCustomise()
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/src/Configuration/Applications/python/ConfigBuilder.py", line 896, in addCustomise
    __import__(packageName)
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/src/PhysicsTools/NanoAOD/python/custom_jme_cff.py", line 12, in <module>
    from PhysicsTools.NanoAOD.jetsAK4_CHS_cff import jetTable, jetCorrFactorsNano, updatedJets, finalJets, qgtagger, hfJetShowerShapeforNanoAOD
ImportError: cannot import name 'hfJetShowerShapeforNanoAOD' from 'PhysicsTools.NanoAOD.jetsAK4_CHS_cff' (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/src/PhysicsTools/NanoAOD/python/jetsAK4_CHS_cff.py)

Can you please have a look?

[vlimant]

sure, how can I reproduce this ?

[perrotta]

sure, how can I reproduce this ?

By running the failing workflows:
10224.15
11024.15
11634.15
25202.15

[vlimant]

we'll do that as soon as there's an IB available ; we do not find CMSSW_12_6_X_2022-11-09* for now