Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep] cleanup file names #36021

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Nov 6, 2021

PR description:

addresses issue #33373 and comments on #36004

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@ianna
Copy link
Contributor Author

ianna commented Nov 6, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36021/26472

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@ianna
Copy link
Contributor Author

ianna commented Nov 6, 2021

please test

@qliphy
Copy link
Contributor

qliphy commented Nov 9, 2021

@cms-sw/pdmv-l2 This is needed to fix IB issues #36029 Would you please have a quick check?

@kskovpen
Copy link
Contributor

kskovpen commented Nov 9, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 9, 2021

+1

@cmsbuild cmsbuild merged commit 322cf40 into cms-sw:master Nov 9, 2021
@srimanob srimanob mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment