Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036

bsunanda · 2021-11-08T15:02:01Z

PR description:

Add layeroffset attribute to 6-inch wafer geometry files for HGCal

PR validation:

Tested using the workflows for HGCal TB which uses 6-inch wafer

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2021-11-08T15:09:20Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36036/26491

This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36036/26491/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36036/26491/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36036/26491/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36036/26491/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-11-08T15:25:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36036/26492

This PR adds an extra 36KB to repository

cmsbuild · 2021-11-08T15:26:19Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-11-08T18:23:51Z

@cmsbuild Please test

cmsbuild · 2021-11-08T19:41:20Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-471a98/20344/summary.html
COMMIT: b770917
CMSSW: CMSSW_12_2_X_2021-11-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36036/20344/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

11634.911

----- Begin Fatal Exception 08-Nov-2021 19:53:46 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'EcalBarrelGeometryEPdd4hep' in category 'CMS EDM Framework ParameterSet Description'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

bsunanda · 2021-11-09T12:01:42Z

@cmsbuild Please test

srimanob · 2021-11-09T13:10:09Z

please abort

To pass, you will need #36021 for now. I will retrigger the test with it.

bsunanda · 2021-11-09T17:56:39Z

@cmsbuild please test with #36021

cmsbuild · 2021-11-09T18:01:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36036/26529

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/python/testHGCV7XML_cfi.py modified in PR(s): Phase2-hgx295 Change copper cover to SS cover and remove many obsolete files of HGCal geometry #36061
- File Geometry/HGCalCommonData/python/testHGCV8XML_cfi.py modified in PR(s): Phase2-hgx295 Change copper cover to SS cover and remove many obsolete files of HGCal geometry #36061
- File Geometry/HGCalCommonData/src/HGCalGeomParameters.cc modified in PR(s): Phase2-hgx294C Make sure that all rings of scinitllators are included in the definitions of HGCalGeometry #36045

cmsbuild · 2021-11-09T18:01:36Z

Pull request #36036 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please check and sign again.

cmsbuild · 2021-11-09T21:15:28Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-471a98/20406/summary.html
COMMIT: 0398b56
CMSSW: CMSSW_12_2_X_2021-11-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36036/20406/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 2901890
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2901856
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

cvuosalo · 2021-11-11T00:09:21Z

Geometry/HGCalCommonData/src/HGCalGeomParameters.cc

@@ -1223,6 +1228,14 @@ void HGCalGeomParameters::loadSpecParsHexagon(const cms::DDFilteredView& fv,
  php.cellSize_ = fv.get<std::vector<double> >(sdTag3, "CellSize");
  rescale(php.cellSize_, HGCalParameters::k_ScaleFromDD4hepToG4);

+  // Layer Offset
+  const auto& dummy2 = fv.get<std::vector<double> >(sdTag1, "LayerOffset");


layerOffset would be a more instructive name for this constant than dummy2.

cvuosalo · 2021-11-11T00:09:33Z

+1

srimanob · 2021-11-11T01:52:41Z

+Upgrade

cmsbuild · 2021-11-11T01:53:05Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-11-11T05:13:06Z

+1

Add layeroffset attribute to v6 geometry files for HGCal

32c603e

cmsbuild added this to the CMSSW_12_2_X milestone Nov 8, 2021

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Nov 8, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 8, 2021

Code check

b770917

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 8, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 8, 2021

cmsbuild added tests-started and removed tests-pending labels Nov 8, 2021

cmsbuild added tests-rejected and removed tests-started labels Nov 8, 2021

cmsbuild mentioned this pull request Nov 9, 2021

Phase2-hgx294C Make sure that all rings of scinitllators are included in the definitions of HGCalGeometry #36045

Merged

cmsbuild added tests-started and removed tests-rejected labels Nov 9, 2021

cmsbuild removed the tests-started label Nov 9, 2021

cmsbuild added code-checks-pending tests-pending and removed requires-external code-checks-approved labels Nov 9, 2021

cmsbuild added requires-external tests-started and removed tests-pending labels Nov 9, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 9, 2021

cmsbuild added tests-approved and removed tests-started labels Nov 9, 2021

cvuosalo reviewed Nov 11, 2021

View reviewed changes

cmsbuild added geometry-approved and removed geometry-pending labels Nov 11, 2021

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Nov 11, 2021

cmsbuild added orp-approved and removed orp-pending labels Nov 11, 2021

cmsbuild merged commit bdd8e05 into cms-sw:master Nov 11, 2021

cmsbuild mentioned this pull request Nov 11, 2021

Move to root 6.24 cms-sw/cmsdist#7445

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036

Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036

bsunanda commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

bsunanda commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

bsunanda commented Nov 9, 2021

srimanob commented Nov 9, 2021 •

edited

Loading

bsunanda commented Nov 9, 2021

cmsbuild commented Nov 9, 2021

cmsbuild commented Nov 9, 2021

cmsbuild commented Nov 9, 2021

cvuosalo Nov 11, 2021

cvuosalo commented Nov 11, 2021

srimanob commented Nov 11, 2021

cmsbuild commented Nov 11, 2021

qliphy commented Nov 11, 2021

Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036

Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036

Conversation

bsunanda commented Nov 8, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

bsunanda commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

RelVals

bsunanda commented Nov 9, 2021

srimanob commented Nov 9, 2021 • edited Loading

bsunanda commented Nov 9, 2021

cmsbuild commented Nov 9, 2021

cmsbuild commented Nov 9, 2021

cmsbuild commented Nov 9, 2021

Comparison Summary

cvuosalo Nov 11, 2021

Choose a reason for hiding this comment

cvuosalo commented Nov 11, 2021

srimanob commented Nov 11, 2021

cmsbuild commented Nov 11, 2021

qliphy commented Nov 11, 2021

srimanob commented Nov 9, 2021 •

edited

Loading