Fix trivial bugs in test (VertexFinder_t.h)

[VinInn]

found by ASAN #36057

[VinInn]

@cmsbuild , please test

[VinInn]

enable gpu

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36058/26517

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

• RecoPixelVertexing/PixelVertexFinding (reconstruction)

@jpata, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[VinInn]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36058/26519

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #36058 was updated. @jpata, @slava77 can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61dd4c/20382/summary.html
COMMIT: 71bc27d
CMSSW: CMSSW_12_2_X_2021-11-08-2300/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36058/20382/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @iarspider Remove references to standalone keras #36032
• @dan131riley Fix errors in RepeatingCachedRootSource test #36006
• @cms-tsg-storm HLT menu development for 12_2_X #36034
• @missirol improvement of a workaround in customizeHLTforPatatrack #36031
• @ianna [DD4hep] cleanup file names #36021
• @tvami Change to new method in PoolDBOutputService for SiPixel CPE #36027
• @Dr15Jones Fixed crash in RepeatingCachedRootSource #36042
• @Sam-Harper Adding Proxy Support to hltGetConfiguration and fixing converter/db specification bugs with hltIntegrationTests #35987

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61dd4c/20382/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61dd4c/20382/git-merge-result

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19782
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19775
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: found differences in 3 / 3 workflows

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.911 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 2694539
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2694498
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 40 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 173 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: found differences in 4 / 40 workflows

[slava77]

+reconstruction

for #36058 71bc27d

• code changes are following the issue [ASAN] heap-buffer-overflow in ClusterGenerator::operator() #36057, affecting only RecoPixelVertexing/PixelVertexFinding/test/VertexFinder_t.h
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1