Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMT/RMT preparation for Run3 #36049

Closed
wants to merge 89 commits into from

Conversation

zhokin2
Copy link
Contributor

@zhokin2 zhokin2 commented Nov 9, 2021

PR description:

CMT: new plots regarding GlobalRMT added;
tiny update of some titles;
update of condor related scripts;

RMT: update on scripts to run crontab using local runs;
psm-plots added: update on macros;
general cc-code was changed with energy-eraw exchange for HBHE;

PR validation:

I've used the commands:

scram build code-checks
scram build code-format
scram b

and testing all scripts on real data

@zhokin2
Copy link
Contributor Author

zhokin2 commented Nov 11, 2021

Tiny update on 2 txt files, and
I've tried to rewrite very often history of commits using:
git reset --soft da3cbc6
git commit --amend

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36049/26571

  • This PR adds an extra 212KB to repository

@cmsbuild
Copy link
Contributor

Pull request #36049 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@jfernan2
Copy link
Contributor

@zhokin2 if you are done with commits, could you squash them into a single one please?

@zhokin2
Copy link
Contributor Author

zhokin2 commented Nov 15, 2021

@zhokin2 if you are done with commits, could you squash them into a single one please?

I did that 4 days ago as:
git reset --soft da3cbc6
git commit --amend

@jfernan2
Copy link
Contributor

I am sorry but git declares 85 commits for this PR....

@abdoulline
Copy link

abdoulline commented Nov 15, 2021

@zhokin2 did you edit the txt file opened by
git commit --amend

It opens a txt file with your editor, containig the commented info and a list of all the (85) commits, so you have to add some meaningful comment at the beginning of the file before the following lines:

...
Please enter the commit message for your changes. Lines starting
with '#' will be ignored, and an empty message aborts the commit.

@zhokin2
Copy link
Contributor Author

zhokin2 commented Nov 16, 2021 via email

@abdoulline
Copy link

Well, I don't see anything changed on the github...
https://github.com/cms-sw/cmssw/compare/master...zhokin2:12_2_0_pre1_CMTforRun3?expand=1

A naive questions: did you "push" the changes:
git push my-cmssw 12_2_0_pre1_CMTforRun3

@zhokin2
Copy link
Contributor Author

zhokin2 commented Nov 16, 2021 via email

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36049/26657

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

Pull request #36049 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@zhokin2 zhokin2 closed this Nov 16, 2021
@zhokin2 zhokin2 deleted the 12_2_0_pre1_CMTforRun3 branch November 16, 2021 09:59
@zhokin2 zhokin2 restored the 12_2_0_pre1_CMTforRun3 branch November 16, 2021 10:01
@zhokin2 zhokin2 deleted the 12_2_0_pre1_CMTforRun3 branch November 16, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants