-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMT/RMT preparation for Run3 #36049
CMT/RMT preparation for Run3 #36049
Conversation
…mssw into 12_2_0_pre1_CMTforRun3
Tiny update on 2 txt files, and |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36049/26571
|
Pull request #36049 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
@zhokin2 if you are done with commits, could you squash them into a single one please? |
I am sorry but git declares 85 commits for this PR.... |
@zhokin2 did you edit the txt file opened by It opens a txt file with your editor, containig the commented info and a list of all the (85) commits, so you have to add some meaningful comment at the beginning of the file before the following lines: ... |
someting was wrong from my side - thanks , now it's corrected for sure: git log do not show 85 commits
…________________________________
From: Salavat Abdullin ***@***.***
Sent: 15 November 2021 20:56
To: cms-sw/cmssw
Cc: Alexandr Zhokin; Mention
Subject: Re: [cms-sw/cmssw] CMT/RMT preparation for Run3 (PR #36049)
@zhokin2<https://github.com/zhokin2> did you edit the txt file opened by
git commit --amend
It opens a txt file with your editor, containig the commented info and a list of all the (85) commits, so you have to add some meaningful comment at the beginning of the file before the following lines:
Please enter the commit message for your changes. Lines starting
with '#' will be ignored, and an empty message aborts the commit.
<...>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#36049 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACHOUBBNABDWNPEK5QOA44LUMFQW7ANCNFSM5HUULFVQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Well, I don't see anything changed on the github... A naive questions: did you "push" the changes: |
Sorry, now git push done as well
…________________________________
From: Salavat Abdullin ***@***.***
Sent: 16 November 2021 07:50
To: cms-sw/cmssw
Cc: Alexandr Zhokin; Mention
Subject: Re: [cms-sw/cmssw] CMT/RMT preparation for Run3 (PR #36049)
Well, I don't see anything changed on the github...
https://github.com/cms-sw/cmssw/compare/master...zhokin2:12_2_0_pre1_CMTforRun3?expand=1
A naive questions: did you "push" the changes:
git push my-cmssw 12_2_0_pre1_CMTforRun3
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#36049 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACHOUBGZ2SCQOJZCMEADS5DUMH5JVANCNFSM5HUULFVQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36049/26657
|
Pull request #36049 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
PR description:
CMT: new plots regarding GlobalRMT added;
tiny update of some titles;
update of condor related scripts;
RMT: update on scripts to run crontab using local runs;
psm-plots added: update on macros;
general cc-code was changed with energy-eraw exchange for HBHE;
PR validation:
I've used the commands:
scram build code-checks
scram build code-format
scram b
and testing all scripts on real data