Switch to Geant4 thermal neutron physics #32009

civanch · 2020-11-02T21:47:37Z

PR description:

Historically in CMSSW thermal neutron physics was constructed by custom class. With Geant4 10.6 and beyond similar physics constructor exist in Geant4 library. In this PR a switch to the Geant4 class is done, which fix problem of adaptation of the new Geant4 version 10.6ref10.

This PR fixes #6356

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport

no

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-11-02T21:48:01Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-11-02T21:55:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32009/19535

This PR adds an extra 16KB to repository

cmsbuild · 2020-11-02T21:55:57Z

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

civanch · 2020-11-02T21:57:01Z

please test

cmsbuild · 2020-11-02T21:57:27Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-11-02-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10456/console Started: 2020/11/02 22:58

civanch · 2020-11-02T21:57:32Z

+1

civanch · 2020-11-02T21:57:46Z

urgent

cmsbuild · 2020-11-02T21:57:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2020-11-02T23:20:18Z

+1
Tested at: d407b69
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65cf38/10456/summary.html
CMSSW: CMSSW_11_2_X_2020-11-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-02T23:20:21Z

Comparison job queued.

cmsbuild · 2020-11-03T02:55:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65cf38/10456/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2544092
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2544063
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

qliphy · 2020-11-03T04:45:09Z

+1

cmsbuild · 2020-11-03T13:07:07Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6356

CMSSW_11_2_GEANT4_X_2020-10-29-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10471/console Started: 2020/11/03 15:10

slomeo · 2020-11-03T13:37:54Z

@civanch : just a curiosity, are there physical diferences (i.e different models for neutrons, etc etc) between CMSThermalNeutrons and G4ThermalNeutrons?

cmsbuild · 2020-11-04T02:26:06Z

-1

Tested at: d407b69

CMSSW: CMSSW_11_2_GEANT4_X_2020-10-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Fireworks 11_2_X Updates for GEM detector visualization #31978 @alja: Fireworks 11_2_X Updates for GEM detector visualization
Run3-gex30 Update the preshowering numbering scheme and a test code #31986 @bsunanda: Run3-gex30 Update the preshowering numbering scheme and a test code
Mini-PR: Fix Z side in Preshower #31983 @ghugo83: Mini-PR: Fix Z side in Preshower
Allow setting connect string from SiteLocalConfig #31544 @wddgit: Allow setting connect string from SiteLocalConfig
Fix bug in NanoGEN precision setting #31973 @kdlong: Fix bug in NanoGEN precision setting
DD4hep RelVal for Phase2: update geometry configuration and PyReleaseValidation #31975 @fabiocos: DD4hep RelVal for Phase2: update geometry configuration and PyReleaseValidation
UL scale and smearing for nanoAOD photons and electrons (2017 and 2018) #31974 @jainshilpi: UL scale and smearing for nanoAOD photons and electrons (2017 and 2018)
[Pixel 3D Digitizer] Include charge generation underneath the n-column #31977 @claralasa: [Pixel 3D Digitizer] Include charge generation underneath the n-column
[DD4hep] Preshower Algo cleanup #31989 @ianna: [DD4hep] Preshower Algo cleanup
add ZDC Digis to HI miniAOD #31971 @mandrenguyen: add ZDC Digis to HI miniAOD
adding MWGR4 run with GEM in Run3 data workflow #31955 @boudoul: adding MWGR4 run with GEM in Run3 data workflow
Run3-gex32 Updates geometry building for EB/EE and solves the issue of failure #31998 @bsunanda: Run3-gex32 Updates geometry building for EB/EE and solves the issue of failure
Revert "PPS Digi integration into cmssw (final)" #31997 @cms-sw: Revert "PPS Digi integration into cmssw (final)"
Run3-gex31 Identify fine detector in CaloSD and refine EcalDumpGeometry #31996 @bsunanda: Run3-gex31 Identify fine detector in CaloSD and refine EcalDumpGeometry

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc14f4/10471/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc14f4/10471/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc14f4/10471/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

Unit Tests:

I found errors in the following unit tests:

---> test MagneticFieldEngineTestDriver had ERRORS

RelVals:

The relvals timed out after 4 hours.

AddOn:

I found errors in the following addon tests:

Preparing to run ['cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run3_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_DATA.rAddOnTest might have timed out: FAILED - secs

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Fireworks 11_2_X Updates for GEM detector visualization #31978 @alja: Fireworks 11_2_X Updates for GEM detector visualization
Run3-gex30 Update the preshowering numbering scheme and a test code #31986 @bsunanda: Run3-gex30 Update the preshowering numbering scheme and a test code
Mini-PR: Fix Z side in Preshower #31983 @ghugo83: Mini-PR: Fix Z side in Preshower
Allow setting connect string from SiteLocalConfig #31544 @wddgit: Allow setting connect string from SiteLocalConfig
Fix bug in NanoGEN precision setting #31973 @kdlong: Fix bug in NanoGEN precision setting
DD4hep RelVal for Phase2: update geometry configuration and PyReleaseValidation #31975 @fabiocos: DD4hep RelVal for Phase2: update geometry configuration and PyReleaseValidation
UL scale and smearing for nanoAOD photons and electrons (2017 and 2018) #31974 @jainshilpi: UL scale and smearing for nanoAOD photons and electrons (2017 and 2018)
[Pixel 3D Digitizer] Include charge generation underneath the n-column #31977 @claralasa: [Pixel 3D Digitizer] Include charge generation underneath the n-column
[DD4hep] Preshower Algo cleanup #31989 @ianna: [DD4hep] Preshower Algo cleanup
add ZDC Digis to HI miniAOD #31971 @mandrenguyen: add ZDC Digis to HI miniAOD
adding MWGR4 run with GEM in Run3 data workflow #31955 @boudoul: adding MWGR4 run with GEM in Run3 data workflow
Run3-gex32 Updates geometry building for EB/EE and solves the issue of failure #31998 @bsunanda: Run3-gex32 Updates geometry building for EB/EE and solves the issue of failure
Revert "PPS Digi integration into cmssw (final)" #31997 @cms-sw: Revert "PPS Digi integration into cmssw (final)"
Run3-gex31 Identify fine detector in CaloSD and refine EcalDumpGeometry #31996 @bsunanda: Run3-gex31 Identify fine detector in CaloSD and refine EcalDumpGeometry

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc14f4/10471/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc14f4/10471/git-merge-result

cmsbuild · 2020-11-04T02:26:11Z

Comparison job queued.

use Geant4 thermal neutron constructor

d407b69

cmsbuild added this to the CMSSW_11_2_X milestone Nov 2, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels Nov 2, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 2, 2020

cmsbuild removed the pending-signatures label Nov 2, 2020

cmsbuild added fully-signed simulation-approved tests-started urgent and removed simulation-pending tests-pending labels Nov 2, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 2, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 3, 2020

cmsbuild added orp-approved and removed orp-pending labels Nov 3, 2020

cmsbuild merged commit cdc8adf into cms-sw:master Nov 3, 2020

mrodozov mentioned this pull request Nov 3, 2020

Update Geant4 to 10.6.10 cms-sw/cmsdist#6356

Merged

cmsbuild added requires-external tests-started and removed tests-approved labels Nov 3, 2020

cmsbuild added comparison-pending tests-rejected and removed comparison-available tests-started labels Nov 4, 2020

cmsbuild mentioned this pull request Nov 4, 2020

RecoVertex/PrimaryVertexProducer: fix heap buffer overflow found by ASAN. #32028

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to Geant4 thermal neutron physics #32009

Switch to Geant4 thermal neutron physics #32009

civanch commented Nov 2, 2020 •

edited

Loading

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

civanch commented Nov 2, 2020

cmsbuild commented Nov 2, 2020 •

edited

Loading

civanch commented Nov 2, 2020

civanch commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 3, 2020

qliphy commented Nov 3, 2020

cmsbuild commented Nov 3, 2020 •

edited

Loading

slomeo commented Nov 3, 2020

cmsbuild commented Nov 4, 2020

cmsbuild commented Nov 4, 2020

Switch to Geant4 thermal neutron physics #32009

Switch to Geant4 thermal neutron physics #32009

Conversation

civanch commented Nov 2, 2020 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

civanch commented Nov 2, 2020

cmsbuild commented Nov 2, 2020 • edited Loading

civanch commented Nov 2, 2020

civanch commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 3, 2020

qliphy commented Nov 3, 2020

cmsbuild commented Nov 3, 2020 • edited Loading

slomeo commented Nov 3, 2020

cmsbuild commented Nov 4, 2020

cmsbuild commented Nov 4, 2020

civanch commented Nov 2, 2020 •

edited

Loading

cmsbuild commented Nov 2, 2020 •

edited

Loading

cmsbuild commented Nov 3, 2020 •

edited

Loading