Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Geant4 to 10.6.10 #6356

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Nov 2, 2020

@civanch would you check the config please ?

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2020

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_2_X/geant4.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Nov 2, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2020

-1

Tested at: df28064

CMSSW: CMSSW_11_2_GEANT4_X_2020-10-29-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0007a/10443/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/HadronPhysicsCMS.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/HadronPhysicsQGSPCMS_FTFP_BERT.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/MonopoleTransportation.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/UrbanMscModel93.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/CMSThermalNeutrons.cc: In member function 'virtual void CMSThermalNeutrons::ConstructProcess()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/CMSThermalNeutrons.cc:23:29: error: 'FindElasticProcess' was not declared in this scope
   G4HadronicProcess* hpel = FindElasticProcess(part);
                             ^~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/CMSThermalNeutrons.cc:23:29: note: suggested alternative: 'ConstructProcess'
   G4HadronicProcess* hpel = FindElasticProcess(part);
                             ^~~~~~~~~~~~~~~~~~


@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2020

Comparison job queued.

@civanch
Copy link
Contributor

civanch commented Nov 2, 2020

@mrodozov , #32009 should fix compilation problem.

@mrodozov
Copy link
Contributor Author

mrodozov commented Nov 3, 2020

please test
I see it's merged now

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

-1

Tested at: df28064

CMSSW: CMSSW_11_2_GEANT4_X_2020-10-29-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0007a/10460/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/HadronPhysicsCMS.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/HadronPhysicsQGSPCMS_FTFP_BERT.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/MonopoleTransportation.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/UrbanMscModel93.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/CMSThermalNeutrons.cc: In member function 'virtual void CMSThermalNeutrons::ConstructProcess()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/CMSThermalNeutrons.cc:23:29: error: 'FindElasticProcess' was not declared in this scope
   G4HadronicProcess* hpel = FindElasticProcess(part);
                             ^~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_GEANT4_X_2020-10-29-2300/src/SimG4Core/PhysicsLists/src/CMSThermalNeutrons.cc:23:29: note: suggested alternative: 'ConstructProcess'
   G4HadronicProcess* hpel = FindElasticProcess(part);
                             ^~~~~~~~~~~~~~~~~~


@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

Comparison job queued.

@mrodozov
Copy link
Contributor Author

mrodozov commented Nov 3, 2020

please test with cms-sw/cmssw#32009

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#32009

@smuzaffar
Copy link
Contributor

Tests are still running but lets get this merged for GEANT4 IB.

@smuzaffar smuzaffar merged commit 34dd1d7 into cms-sw:IB/CMSSW_11_2_X/geant4 Nov 3, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

-1

Tested at: df28064

CMSSW: CMSSW_11_2_GEANT4_X_2020-10-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • #31978 @alja: Fireworks 11_2_X Updates for GEM detector visualization
  • #31986 @bsunanda: Run3-gex30 Update the preshowering numbering scheme and a test code
  • #31983 @ghugo83: Mini-PR: Fix Z side in Preshower
  • #31544 @wddgit: Allow setting connect string from SiteLocalConfig
  • #31973 @kdlong: Fix bug in NanoGEN precision setting
  • #31975 @fabiocos: DD4hep RelVal for Phase2: update geometry configuration and PyReleaseValidation
  • #31974 @jainshilpi: UL scale and smearing for nanoAOD photons and electrons (2017 and 2018)
  • #31977 @claralasa: [Pixel 3D Digitizer] Include charge generation underneath the n-column
  • #31989 @ianna: [DD4hep] Preshower Algo cleanup
  • #31971 @mandrenguyen: add ZDC Digis to HI miniAOD
  • #31955 @boudoul: adding MWGR4 run with GEM in Run3 data workflow
  • #31998 @bsunanda: Run3-gex32 Updates geometry building for EB/EE and solves the issue of failure
  • #31997 @cms-sw: Revert "PPS Digi integration into cmssw (final)"
  • #31996 @bsunanda: Run3-gex31 Identify fine detector in CaloSD and refine EcalDumpGeometry

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc14f4/10471/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc14f4/10471/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc14f4/10471/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

  • Unit Tests:

I found errors in the following unit tests:

---> test MagneticFieldEngineTestDriver had ERRORS

  • RelVals:

The relvals timed out after 4 hours.

  • AddOn:

I found errors in the following addon tests:

Preparing to run ['cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run3_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_DATA.rAddOnTest might have timed out: FAILED - secs

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • #31978 @alja: Fireworks 11_2_X Updates for GEM detector visualization
  • #31986 @bsunanda: Run3-gex30 Update the preshowering numbering scheme and a test code
  • #31983 @ghugo83: Mini-PR: Fix Z side in Preshower
  • #31544 @wddgit: Allow setting connect string from SiteLocalConfig
  • #31973 @kdlong: Fix bug in NanoGEN precision setting
  • #31975 @fabiocos: DD4hep RelVal for Phase2: update geometry configuration and PyReleaseValidation
  • #31974 @jainshilpi: UL scale and smearing for nanoAOD photons and electrons (2017 and 2018)
  • #31977 @claralasa: [Pixel 3D Digitizer] Include charge generation underneath the n-column
  • #31989 @ianna: [DD4hep] Preshower Algo cleanup
  • #31971 @mandrenguyen: add ZDC Digis to HI miniAOD
  • #31955 @boudoul: adding MWGR4 run with GEM in Run3 data workflow
  • #31998 @bsunanda: Run3-gex32 Updates geometry building for EB/EE and solves the issue of failure
  • #31997 @cms-sw: Revert "PPS Digi integration into cmssw (final)"
  • #31996 @bsunanda: Run3-gex31 Identify fine detector in CaloSD and refine EcalDumpGeometry

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc14f4/10471/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc14f4/10471/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

Comparison job queued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants