Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding MWGR4 run with GEM in Run3 data workflow #31955

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Oct 27, 2020

PR description:

This PR is updating the data run3 workflow (prompt reco run 3 workflow 138.1 ) with a recent run where GEM is present in the acquisition.

I didn't update the corresponding express WF (138.2) on purpose in order to keep a run tested with the Strip Tracker ( we do not have a recent run with both detectors..)

We can harmonise better after the MWGR 5 if we manage to get a run with all detectors IN.

PR validation:

runTheMatrix.py -l 138.1 --command "-n 500"

if this PR is a backport please specify the original PR and why you need to backport that PR:

I plan to backport this PR once this PR is integrated or soon to be

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31955/19411

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@boudoul
Copy link
Contributor Author

boudoul commented Oct 27, 2020

Adding @amassiro

@@ -496,6 +496,7 @@

### LS2 - MWGR ###
steps['RunCosmics2020']={'INPUT':InputInfo(dataSet='/ExpressCosmics/Commissioning2019-Express-v1/FEVT',label='2020GR0',run=[334393],events=100000,location='STD')}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @boudoul, shall we remove this step if you wanna replace with RunCosmics2020GEM completely? Otherwise it isn't used elsewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chayanit , sorry I overlooked your comment. As mentioned in the description , I would like to keep as it is the express WF (138.2 using RunCosmics2020 ) in order to keep a run to be tested in IBs with the Strip Tracker. The newly introduced run in the prompt WF (138.1 using RunCosmics2020GEM ) doesn't contain the strip tracker (but GEM)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK fair enough @boudoul

@chayanit
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 0239dd0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6cc701/10377/summary.html
CMSSW: CMSSW_11_2_X_2020-10-28-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6cc701/10377/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544092
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544063
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@kpedro88
Copy link
Contributor

+upgrade

@chayanit
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 30, 2020

+1

@cmsbuild cmsbuild merged commit 5d5e0ee into cms-sw:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants