-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding MWGR4 run with GEM in Run3 data workflow #31955
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31955/19411
|
A new Pull Request was created by @boudoul (boudoul) for master. It involves the following packages: Configuration/PyReleaseValidation @chayanit, @cmsbuild, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Adding @amassiro |
@@ -496,6 +496,7 @@ | |||
|
|||
### LS2 - MWGR ### | |||
steps['RunCosmics2020']={'INPUT':InputInfo(dataSet='/ExpressCosmics/Commissioning2019-Express-v1/FEVT',label='2020GR0',run=[334393],events=100000,location='STD')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @boudoul, shall we remove this step if you wanna replace with RunCosmics2020GEM completely? Otherwise it isn't used elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chayanit , sorry I overlooked your comment. As mentioned in the description , I would like to keep as it is the express WF (138.2 using RunCosmics2020 ) in order to keep a run to be tested in IBs with the Strip Tracker. The newly introduced run in the prompt WF (138.1 using RunCosmics2020GEM ) doesn't contain the strip tracker (but GEM)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK fair enough @boudoul
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is updating the data run3 workflow (prompt reco run 3 workflow 138.1 ) with a recent run where GEM is present in the acquisition.
I didn't update the corresponding express WF (138.2) on purpose in order to keep a run tested with the Strip Tracker ( we do not have a recent run with both detectors..)
We can harmonise better after the MWGR 5 if we manage to get a run with all detectors IN.
PR validation:
runTheMatrix.py -l 138.1 --command "-n 500"
if this PR is a backport please specify the original PR and why you need to backport that PR:
I plan to backport this PR once this PR is integrated or soon to be