Hlt tau validation conditional plotting2 #30701

slehti · 2020-07-15T13:50:55Z

Same as HLTTauDQM: conditional plotting #30243

Removed problematic merge and continued with this new branch HLTTauValidation_ConditionalPlotting2

…etryCompare

…ms::DDSolidShapes

… builders

cmsbuild · 2020-07-21T07:46:16Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-21T07:53:30Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30701/17187

This PR adds an extra 52KB to repository
Found files with invalid states:
- DQMOffline/Trigger/interface/IWrapper.h:
  - Added: 75cdd2f
  - Deleted: e93a6d3
- DQMOffline/Trigger/src/IWrapper.cc:
  - Added: 75cdd2f
  - Deleted: e93a6d3
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/OfflineValidation/plugins/PrimaryVertexValidation.cc modified in PR(s): Clang tidy checks - fix clang warnings #30632
- File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): remove phase2_hgcalV9 modifier #30702, update the tracking material for Phase2 geometry D49 #30126
- File DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py modified in PR(s): Added new DQM GUI support to all Online DQM clients #30592, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQMServices/StreamerIO/plugins/BuildFile.xml modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/DQMFileIterator.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/DQMFileIterator.h modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/DQMMonitoringService.h modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/DQMProtobufReader.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/DQMStreamerReader.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/DQMStreamerReader.h modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/JsonWritingTimeoutPoolOutputModule.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/RamdiskMonitor.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/test/BuildFile.xml modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/test/DQMStreamerOutputRepackerTest.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/test/DQMStreamerWriteJsonAnalyzer.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File FWCore/Framework/src/Worker.cc modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553
- File FWCore/Framework/src/Worker.h modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553
- File FWCore/Framework/test/eventsetup_t.cppunit.cc modified in PR(s): Throw a separate exception if ESGetToken is uninitialized #30506
- File FWCore/Framework/test/stubs/TestStreamProducers.cc modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553
- File FWCore/Framework/test/test_stream_modules_cfg.py modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553
- File Geometry/HGCalCommonData/interface/HGCalTypes.h modified in PR(s): Phase2-hgx255B Remove magic numbers from HGCal geometry codes #30824
- File Geometry/HGCalCommonData/plugins/DDHGCalModule.cc modified in PR(s): Phase2-hgx255A Remove magic number usage in 2 Algos #30777
- File Geometry/HGCalCommonData/plugins/DDHGCalModuleAlgo.cc modified in PR(s): Phase2-hgx255A Remove magic number usage in 2 Algos #30777
- File Geometry/HGCalCommonData/plugins/DDHGCalWaferAlgo.cc modified in PR(s): Phase2-hgx255B Remove magic numbers from HGCal geometry codes #30824
- File Geometry/HGCalCommonData/src/HGCalGeomParameters.cc modified in PR(s): Phase2-hgx255B Remove magic numbers from HGCal geometry codes #30824
- File Geometry/HGCalCommonData/src/HGCalTypes.cc modified in PR(s): Phase2-hgx255B Remove magic numbers from HGCal geometry codes #30824
- File Geometry/MTDNumberingBuilder/src/GeometricTimingDet.cc modified in PR(s): MTD Geometry: updated GeometricTimingDet to remove the residual dependency on DDSolidShape #30834
- File L1Trigger/Configuration/python/L1Trigger_EventContent_cff.py modified in PR(s): Phase2 L1 NN Tau #30505
- File RecoTauTag/RecoTau/python/tools/runTauIdMVA.py modified in PR(s): Add new MVA tau ID for phase II #30341
- File SLHCUpgradeSimulations/Geometry/test/phase2_digi_reco_pixelntuple_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File SimCalorimetry/HGCalSimProducers/python/hgcalDigitizer_cfi.py modified in PR(s): remove phase2_hgcalV9 modifier #30702
- File SimCalorimetry/HcalSimAlgos/src/HcalAmplifier.cc modified in PR(s): Fix improper static_cast of HcalAmplifier #30829
- File Validation/HGCalValidation/test/HGCGeometryCheck.cc modified in PR(s): remove phase2_hgcalV9 modifier #30702
- File Validation/HGCalValidation/test/HGCHitValidation.cc modified in PR(s): remove phase2_hgcalV9 modifier #30702

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30701/17187/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30701/17187/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-07-21T08:01:42Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-21T08:07:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30701/17188

This PR adds an extra 88KB to repository
Found files with invalid states:
- DQMOffline/Trigger/interface/IWrapper.h:
  - Added: 75cdd2f
  - Deleted: e93a6d3
- DQMOffline/Trigger/src/IWrapper.cc:
  - Added: 75cdd2f
  - Deleted: e93a6d3
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/OfflineValidation/plugins/PrimaryVertexValidation.cc modified in PR(s): Clang tidy checks - fix clang warnings #30632
- File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): remove phase2_hgcalV9 modifier #30702, update the tracking material for Phase2 geometry D49 #30126
- File DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py modified in PR(s): Added new DQM GUI support to all Online DQM clients #30592, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQMServices/StreamerIO/plugins/BuildFile.xml modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/DQMFileIterator.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/DQMFileIterator.h modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/DQMMonitoringService.h modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/DQMProtobufReader.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/DQMStreamerReader.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/DQMStreamerReader.h modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/JsonWritingTimeoutPoolOutputModule.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/plugins/RamdiskMonitor.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/test/BuildFile.xml modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/test/DQMStreamerOutputRepackerTest.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File DQMServices/StreamerIO/test/DQMStreamerWriteJsonAnalyzer.cc modified in PR(s): Move DQMServices/StreamerIO to std::filesystem #30811
- File FWCore/Framework/src/Worker.cc modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553
- File FWCore/Framework/src/Worker.h modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553
- File FWCore/Framework/test/eventsetup_t.cppunit.cc modified in PR(s): Throw a separate exception if ESGetToken is uninitialized #30506
- File FWCore/Framework/test/stubs/TestStreamProducers.cc modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553
- File FWCore/Framework/test/test_stream_modules_cfg.py modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553
- File Geometry/HGCalCommonData/interface/HGCalTypes.h modified in PR(s): Phase2-hgx255B Remove magic numbers from HGCal geometry codes #30824
- File Geometry/HGCalCommonData/plugins/DDHGCalModule.cc modified in PR(s): Phase2-hgx255A Remove magic number usage in 2 Algos #30777
- File Geometry/HGCalCommonData/plugins/DDHGCalModuleAlgo.cc modified in PR(s): Phase2-hgx255A Remove magic number usage in 2 Algos #30777
- File Geometry/HGCalCommonData/plugins/DDHGCalWaferAlgo.cc modified in PR(s): Phase2-hgx255B Remove magic numbers from HGCal geometry codes #30824
- File Geometry/HGCalCommonData/src/HGCalGeomParameters.cc modified in PR(s): Phase2-hgx255B Remove magic numbers from HGCal geometry codes #30824
- File Geometry/HGCalCommonData/src/HGCalTypes.cc modified in PR(s): Phase2-hgx255B Remove magic numbers from HGCal geometry codes #30824
- File Geometry/MTDNumberingBuilder/src/GeometricTimingDet.cc modified in PR(s): MTD Geometry: updated GeometricTimingDet to remove the residual dependency on DDSolidShape #30834
- File L1Trigger/Configuration/python/L1Trigger_EventContent_cff.py modified in PR(s): Phase2 L1 NN Tau #30505
- File RecoTauTag/RecoTau/python/tools/runTauIdMVA.py modified in PR(s): Add new MVA tau ID for phase II #30341
- File SLHCUpgradeSimulations/Geometry/test/phase2_digi_reco_pixelntuple_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File SimCalorimetry/HGCalSimProducers/python/hgcalDigitizer_cfi.py modified in PR(s): remove phase2_hgcalV9 modifier #30702
- File SimCalorimetry/HcalSimAlgos/src/HcalAmplifier.cc modified in PR(s): Fix improper static_cast of HcalAmplifier #30829
- File Validation/HGCalValidation/test/HGCGeometryCheck.cc modified in PR(s): remove phase2_hgcalV9 modifier #30702
- File Validation/HGCalValidation/test/HGCHitValidation.cc modified in PR(s): remove phase2_hgcalV9 modifier #30702

cmsbuild · 2020-07-21T08:08:23Z

Pull request #30701 was updated. @SiewYan, @andrius-k, @jpata, @chayanit, @emeschi, @wajidalikhan, @schneiml, @ianna, @kpedro88, @Martin-Grunewald, @rekovic, @gouskos, @fioriNTU, @tlampen, @alberto-sanchez, @pohsun, @santocch, @peruzzim, @perrotta, @civanch, @makortel, @cmsbuild, @agrohsje, @fwyzard, @GurpreetSinghChahal, @smuzaffar, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @tocheng, @slava77, @ggovi, @qliphy, @benkrikler, @mkirsano, @kmaeshima, @christopheralanwest, @pgunnell, @alja, @fgolf, @mommsen, @mariadalfonso can you please check and sign again.

perrotta · 2020-07-21T08:17:03Z

-1
Please rebase to get rid of unrelated commits

slehti · 2020-07-21T10:05:52Z

Did not manage to rebase. Cherry-picked, refused to be added in this branch. Closing, and continuing in branch HLTTauValidation_ConditionalPlotting3.

slehti and others added 30 commits June 15, 2020 12:52

HLTTauDQM: conditional plotting

75cdd2f

HLTTauDQM: renamed IWrapper -> HistoWrapper

e93a6d3

HLTTauDQM: applied code-format patch

c5752d7

First shot at DD4HEP migration for CondTools/Geometry and TrackerGeom…

f40eb91

…etryCompare

Migrate TrackerNumberingBuilder to DD4HEP-SolidShapes

2518ef8

Cast to cms::DDSolidShape in MTD GeometricTimingDet

20e87b6

PGeometricDetBuilder: code format

32a426c

Removing some old DD headers

9dc0976

Make Tk plugins handle both old DD and DD4hep

7b51564

Apply CodeFormat

98f81f1

Add reverse lookup for LegacySolidShape mape and define unsupported c…

31f7356

…ms::DDSolidShapes

Apply code format

2b604b4

Remove commented line

71f85b4

Make fromDD4hep a tracked parameter in GeometricDet/TrackerParameters…

2213b04

… builders

Cleanup in TrackerGeometryCompare

c46fd75

SolidShapes enum back to original

dec61a7

Code checks

059a143

Removing TrackerNumberingBuilder/bin/stubs/GeometricDetLoader

8801ff3

Reduce DDExpandedView use in GeometricDet and add shape_dd4hep

6645190

Code format

8a2e981

Match enums for Legacy and DD4hep SolidShapes

ed8b751

Update DDSolidLegacyShapes unit test

dcff114

Apply code format

af5c936

DDSolidLegacyShapes conflict fix attempt

fbe5d2a

GeometricDet: have shape_dd4hep return by value

285678b

GeometricDet: fix include

823074d

Code format

637ae06

adding delayQIE method to mimic phase scan

bf72c26

preserve calo sample info first

52d0eda

HLTTauDQM: fixed L1ETMEtEffDenom and changed L1 ETM as vital plot

eb6da88

cmsbuild added geometry-pending heterogeneous-pending hlt-pending l1-pending pdmv-pending reconstruction-pending simulation-pending tests-pending upgrade-pending visualization-pending xpog-pending labels Jul 21, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 21, 2020

Applied code format patch

a56e6ab

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 21, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 21, 2020

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels Jul 21, 2020

slehti closed this Jul 21, 2020

slehti mentioned this pull request Jul 21, 2020

Hlt tau validation conditional plotting3 #30845

Closed

slehti mentioned this pull request Aug 11, 2020

Hlt tau validation conditional plotting4 #31117

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hlt tau validation conditional plotting2 #30701

Hlt tau validation conditional plotting2 #30701

slehti commented Jul 15, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

perrotta commented Jul 21, 2020

slehti commented Jul 21, 2020

Hlt tau validation conditional plotting2 #30701

Hlt tau validation conditional plotting2 #30701

Conversation

slehti commented Jul 15, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

perrotta commented Jul 21, 2020

slehti commented Jul 21, 2020