Hlt tau validation conditional plotting4

[slehti]

Same as HLTTauDQM: conditional plotting #30243, #30701 and #30845

Now hopefully everything fixed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31117/17692

• This PR adds an extra 72KB to repository

• Found files with invalid states:

  • DQMOffline/Trigger/interface/IWrapper.h:
    • Added: f481aee
    • Deleted: 945fe1c
  • DQMOffline/Trigger/src/IWrapper.cc:
    • Added: f481aee
    • Deleted: 945fe1c

[cmsbuild]

A new Pull Request was created by @slehti for master.

It involves the following packages:

DQMOffline/Trigger

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@missirol, @mtosi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @cericeci, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-11-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8722/console Started: 2020/08/12 10:47

[cmsbuild]

+1
Tested at: d814f46
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a52bd0/8722/summary.html
CMSSW: CMSSW_11_2_X_2020-08-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a52bd0/8722/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2608246
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 8
• DQMHistoTests: Total successes: 2608181
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1239.366 KiB( 34 files compared)
• DQMHistoSizes: changed ( 1000.0 ): -70.656 KiB HLT/TAU
• DQMHistoSizes: changed ( 10024.0,... ): -4.231 KiB HLT/TAU
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 11634.0,... ): -563.544 KiB HLT/TAU
• DQMHistoSizes: changed ( 4.22 ): -17.601 KiB HLT/TAU
• DQMHistoSizes: changed ( 7.3,... ): -3.550 KiB HLT/TAU
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[jfernan2]

@slehti there are at least two workflows (11634.0 and 12434.0) which have HLT/TAU plots with no entries now, is this expected?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2020-08-11-2300+a52bd0/38308/dqm-histo-comparison-summary.html

[slehti]

Checked workflows 11634.0 and 12434.0. Both the baseline and pr histograms have no entries. Why they are reported as changed plots, is probably due to the x-axis, which has changed.

[jfernan2]

Blue is baseline, black is your PR, there are entries in blue:
https://tinyurl.com/y39pzzng
https://tinyurl.com/y4e4x9ls

[slehti]

For some reason cant open the GUI. However, I can open the rootfiles
11634.0 baseline rootjs vs 11634.0 pr rootjs
12434.0 baseline rootjs vs 12434.0 pr rootjs
and there I see for the same plots as in your tinyurl the same for baseline and pr. Exactly what expected. Perhaps the markers are overlapping in the overlay GUI?
Example for the L1 (11634.0)
http://cmsdoc.cern.ch/~slehti/base.png
http://cmsdoc.cern.ch/~slehti/pr.png

[jfernan2]

OK, I see now: what has changed is the number of x bins, hence the number of entries (2 per bin). Thanks

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1