Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hlt tau validation conditional plotting3 #30845

Closed

Conversation

slehti
Copy link
Contributor

@slehti slehti commented Jul 21, 2020

Same as HLTTauDQM: conditional plotting #30243 and #30701.

Did not manage to rebase #30701. Cherry-picked, refused to be added in branch HLTTauValidation_ConditionalPlotting2.
Closing, and continuing in branch HLTTauValidation_ConditionalPlotting3.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30845/17190

  • This PR adds an extra 48KB to repository

  • Found files with invalid states:

    • DQMOffline/Trigger/interface/IWrapper.h:
    • DQMOffline/Trigger/src/IWrapper.cc:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slehti for master.

It involves the following packages:

DQMOffline/Trigger

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@missirol, @mtosi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @cericeci, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 21, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: d75649c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-948c55/8164/summary.html
CMSSW: CMSSW_11_2_X_2020-07-20-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-948c55/8164/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2522311
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 2522247
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1151.455 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -67.925 KiB HLT/TAU
  • DQMHistoSizes: changed ( 10024.0,... ): -4.231 KiB HLT/TAU
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 11634.0,... ): -520.954 KiB HLT/TAU
  • DQMHistoSizes: changed ( 4.22 ): -17.601 KiB HLT/TAU
  • DQMHistoSizes: changed ( 7.3,... ): -3.550 KiB HLT/TAU
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

Thanks @slehti for this cleaning.
At least two workflows (11634.0 and 12434.0) do not get some (82) HLT/TAU plots removed but instead get 0 stats:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2020-07-20-2300+948c55/37860/dqm-histo-comparison-summary.html
It would be nice to remove them to not store empty MEs which may confuse TAU POG

@silviodonato
Copy link
Contributor

Kind reminder @slehti

1 similar comment
@silviodonato
Copy link
Contributor

Kind reminder @slehti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants