Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NanoAODv6 updates [102X] #28145

Merged
merged 44 commits into from
Oct 22, 2019
Merged

NanoAODv6 updates [102X] #28145

merged 44 commits into from
Oct 22, 2019

Conversation

peruzzim
Copy link
Contributor

@peruzzim peruzzim commented Oct 10, 2019 •
edited
Loading

backport #28122

PR description:

This pull request is the backport to 10_2_X of the updates for the NanoAODv6 campaign.
It's a cumulative backport of #28103 and #28122.
Depends on #28095 and #28135.

PR validation:

Usual validation in the cms-nanoAOD integration repository.

dmajumder and others added 30 commits May 17, 2019 17:41
@dmajumder
Merged master-102X from repository cms-nanoAOD with cms-merge-topic
8ed3718
@dmajumder
Adding mass-nondecorrelated DeepDoubleX taggers; renaming the mass-de…
7a145fe 
…correlated DeepDoubleX taggers to make it explicit
@dmajumder
renaming DeepDoubleX taggers (restoring names of mass-decorrelated ta…
88c8590 
…ggers and new explicit names for non-mass-decoreelated taggers)
@peruzzim
Merge pull request #375 from peruzzim/branch_10_2_15
0abc6e7 
Update master-102X to CMSSW_10_2_15
@peruzzim
Merge pull request #387 from peruzzim/branch_10_2_16
bde89d0 
Update master-102X to 10_2_16
@mbluj
Add DeepTau2017v2 variables to the tau table
66b9e97
@mbluj
Allow adding to existing tauEmbedder
d5fb42c
@mbluj
Add DeepTauID to nano sequene
063e057
@peruzzim
Remove DeepTauV2 from default nanoAOD DQM config
8fbe60a
@peruzzim
Merge pull request #388 from cms-tau-pog/CMSSW_10_2_X_tau-pog_DeepTau…
4147ed9 
…2017v2_nanoAOD

DeepTauID to Nano at 102X (2nd try)
@peruzzim
Fix vtx cosTheta formula (by @amartelli)
cdb72ea
@mbluj
Add DeepTau2017v2 variables to the tau table
47bc51f
@mbluj
Allow adding to existing tauEmbedder
fb3f013
@mbluj
Add DeepTauID to nano sequene
4b0ce4c
@peruzzim @mbluj
Remove DeepTauV2 from default nanoAOD DQM config
163ed98
@mbluj
Run deepTau2017v2p1, i.e. v2 with disabled dxy_PCA, instead of v2
bafdce1
@mbluj
Merge remote-tracking branch 'cms-nanoAOD/master-102X' into CMSSW_10_…
2f519f5 
…2_X_tau-pog_DeepTau2017v2p1_nanoAOD
@dmajumder
changing names of MD btagDDX taggers
c1b29e2
@peruzzim
Add GenModel event strings to NanoAOD
a4372f5
@peruzzim
Allow for samples without GenLumiInfoHeader product
2aaa966
@peruzzim
Merge pull request #398 from peruzzim/fixesForNanoV6_alternativeModel…
8c77a1e 
…Impl

Save model string in randomized parameter scans + fix vtx formula
@peruzzim
Merge pull request #396 from cms-tau-pog/CMSSW_10_2_X_tau-pog_DeepTau…
4e0ba74 
…2017v2p1_nanoAOD

Update DeepTauID to ver. 2017v2p1
@peruzzim
Fix ordering in nanoDQM_cfi.py
50190c9
@peruzzim
Merge pull request #371 from dmajumder/nanoAOD-CMSSW_10_2_X
47e7391 
Add non-decorrelated DeepDoubleX tagger scores
@IzaakWN @peruzzim
remove trigger object redundancy of OverlapFilterIsoEle bits 8 and 64…
a2f4b31 
…, cfr. OverlapFilterIsoMu
@peruzzim
Merge pull request #404 from cms-nanoAOD/port_pr_395_102X
1dd53c9 
Port PR 395 to 102X
@peruzzim
Activate DeepTauV2p1 in all releases
1a4c92c
@peruzzim
Disable deepTau in 80X
40a8011
@peruzzim
Cleanup and do not run deepTau on 80X
d0c26c7
@peruzzim
Merge pull request #407 from peruzzim/activate_DeepTauV2p1
745db20 
Activate DeepTauV2p1 in all releases
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3c6d3/2937/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 163 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007468
  • DQMHistoTests: Total failures: 39
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3007236
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7.903 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 7.903 KiB Physics/NanoAODDQM
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@peruzzim
Copy link
Contributor Author

please test workflow 1325.6,1325.7,1325.8,1329.1,136.7722,136.7952,136.8521 with #28095,#28135

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 21, 2019 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) #28095,#28135
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3051/console Started: 2019/10/21 14:27

@cmsbuild
Copy link
Contributor

+1
Tested at: 9547ba3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3c6d3/3051/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3c6d3/3051/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 163 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007468
  • DQMHistoTests: Total failures: 39
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3007236
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7.903 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 7.903 KiB Physics/NanoAODDQM
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f44285a into cms-sw:CMSSW_10_2_X Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved backport-ok comparison-available fully-signed orp-approved reconstruction-approved requires-external tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_10_2_X
Development

Successfully merging this pull request may close these issues.