Backport jetid updates #27184 #27691 to 102X

[knash]

Backport of jetid updates to 102X
#27184, #27691

[cmsbuild]

A new Pull Request was created by @knash for CMSSW_10_2_X.

It involves the following packages:

PhysicsTools/SelectorUtils

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2743/console Started: 2019/10/02 06:03

[cmsbuild]

+1
Tested at: f5cd648
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3318f2/2743/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3318f2/2743/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007468
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007274
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[perrotta]

+1

• With this PR PhysicsTools/SelectorUtils/interface/PFJetIDSelectionFunctor.h becomes identical to the one in the master
• Only affected output is expected to be nanoAOD: this PR is therefore suitable to be backported into a closed release.
• Jenkins tests pass and show no differences but in the nanoAOD for jet-id

[fabiocos]

@peruzzim @fgolf please check, is this backport ok for you?

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #28145,#28135
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2937/console Started: 2019/10/15 09:34

[cmsbuild]

+1
Tested at: f5cd648
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3c6d3/2937/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3c6d3/2937/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 163 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007468
• DQMHistoTests: Total failures: 39
• DQMHistoTests: Total nulls: 3
• DQMHistoTests: Total successes: 3007236
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 7.903 KiB( 30 files compared)
• DQMHistoSizes: changed ( 1325.7 ): 7.903 KiB Physics/NanoAODDQM
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #28145,#28135
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3051/console Started: 2019/10/21 14:27

[cmsbuild]

+1
Tested at: f5cd648
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3c6d3/3051/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3c6d3/3051/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 163 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007468
• DQMHistoTests: Total failures: 39
• DQMHistoTests: Total nulls: 3
• DQMHistoTests: Total successes: 3007236
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 7.903 KiB( 30 files compared)
• DQMHistoSizes: changed ( 1325.7 ): 7.903 KiB Physics/NanoAODDQM
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[fabiocos]

+1