Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DeepTauID to ver. 2017v2p1 #396

Conversation

mbluj
Copy link

@mbluj mbluj commented Aug 29, 2019

PR description:

This PR updates DeepTauID to ver. 2017v2p1 containing fix which removes big data-MC discrepancy (by disableing usage of dxy_PCA coordinates). In this way DeepTauID ver. 2017v2 added in #388 is superseded.

This PR is inline with cms-sw#27878 to master of official CMSSW and its backport to 10_2_X cms-sw#27879.

The PR is build on top of CMSSW_10_2_X as for 28.08.2019.

PR validation:

Validated with nanoAOD workflow obtained with the following cmsDriver command which corresponds with NanoAODv5:

cmsDriver.py RunIIFall17NanoAODv5 --filein /store/mc/RunIIFall17MiniAODv2/TTToHadronic_TuneCP5_13TeV-powheg-pythia8/MINIAODSIM/PU2017_12Apr2018_94X_mc2017_realistic_v14-v1/40000/A256C80D-0943-E811-998E-7CD30AB0522C.root --fileout file:RunIIFall17NanoAODv5.root --mc --eventcontent NANOAODSIM --datatier NANOAODSIM --conditions auto:phase1_2017_realistic --step NANO --nThreads 2 --era Run2_2017,run2_nanoAOD_102Xv1 --no_exec -n 1000

as well as with its version without run2_nanoAOD_102Xv1 era specifier.

@mbluj mbluj force-pushed the CMSSW_10_2_X_tau-pog_DeepTau2017v2p1_nanoAOD branch from 4ebcb60 to bafdce1 Compare August 30, 2019 09:01
@mbluj
Copy link
Author

mbluj commented Aug 30, 2019

Synced with master-102X to solve merge conflicts; ready to go.

@gpetruc-bot
Copy link

Copy link

@gpetruc-bot gpetruc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic test report for 1105371

Code integration

Code checks passed for this PR

Tests

  • Long test data102X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data80X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data80Xhip (3000 events): passed, with differences; dqm plots: all, diff
  • Long test data94X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data94X2016 (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data94Xv2 (10000 events): passed, with differences; dqm plots: all, diff
  • Long test mc102X (9000 events): passed, with differences; dqm plots: all, diff
  • Long test mc80X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test mc94X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test mc94X2016 (9000 events): passed, with differences; dqm plots: all, diff
  • Long test mc94Xv2 (9000 events): passed, with differences; dqm plots: all, diff
  • Test mc_94Xv2: passed
  • Test mc_102X: passed
  • Test data_94X: passed
  • Test data_102X: passed

Disk size report

Sample kb/event ref kb/event diff
TTbar MC 102X 1.829 1.831 -0.002 ( -0.1% )
TTbar MC 94Xv1 1.922 1.924 -0.002 ( -0.1% )
TTbar MC 94Xv2 1.956 1.956 -0.001 ( -0.0% )
TTbar MC 94X2016 1.743 1.744 -0.001 ( -0.1% )
TTbar MC 80X 1.901 1.902 -0.001 ( -0.1% )
Data 102X 0.962 0.962 -0.001 ( -0.1% )
Data 94Xv1 0.913 0.914 -0.001 ( -0.1% )
Data 80X 0.793 0.793 -0.000 ( -0.0% )
Data 80X, Mu Run2016E 0.774 0.775 -0.001 ( -0.1% )

@mbluj mbluj deleted the CMSSW_10_2_X_tau-pog_DeepTau2017v2p1_nanoAOD branch October 10, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants