forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DeepTauID to ver. 2017v2p1 #396
Merged
peruzzim
merged 14 commits into
cms-nanoAOD:master-102X
from
cms-tau-pog:CMSSW_10_2_X_tau-pog_DeepTau2017v2p1_nanoAOD
Sep 20, 2019
Merged
Update DeepTauID to ver. 2017v2p1 #396
peruzzim
merged 14 commits into
cms-nanoAOD:master-102X
from
cms-tau-pog:CMSSW_10_2_X_tau-pog_DeepTau2017v2p1_nanoAOD
Sep 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te_ADG_hostnames Update the ADG database host names used by ConfDB (10.2.x)
mbluj
force-pushed
the
CMSSW_10_2_X_tau-pog_DeepTau2017v2p1_nanoAOD
branch
from
August 30, 2019 09:01
4ebcb60
to
bafdce1
Compare
…2_X_tau-pog_DeepTau2017v2p1_nanoAOD
Synced with master-102X to solve merge conflicts; ready to go. |
gpetruc-bot
added
test scheduled (bot)
test started (bot)
and removed
to be tested by bot
test scheduled (bot)
labels
Sep 20, 2019
Automatic test started, see https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/1105371/builds |
gpetruc-bot
reviewed
Sep 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatic test report for 1105371
- gitlab pipeline at https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/1105371/builds
- outputs at https://cms-nanoaod-integration.web.cern.ch/integration/test_pr_396/
Code integration
Code checks passed for this PR
Tests
- Long test data102X (10000 events): passed, with differences; dqm plots: all, diff
- Long test data80X (10000 events): passed, with differences; dqm plots: all, diff
- Long test data80Xhip (3000 events): passed, with differences; dqm plots: all, diff
- Long test data94X (10000 events): passed, with differences; dqm plots: all, diff
- Long test data94X2016 (10000 events): passed, with differences; dqm plots: all, diff
- Long test data94Xv2 (10000 events): passed, with differences; dqm plots: all, diff
- Long test mc102X (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc80X (10000 events): passed, with differences; dqm plots: all, diff
- Long test mc94X (10000 events): passed, with differences; dqm plots: all, diff
- Long test mc94X2016 (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc94Xv2 (9000 events): passed, with differences; dqm plots: all, diff
- Test mc_94Xv2: passed
- Test mc_102X: passed
- Test data_94X: passed
- Test data_102X: passed
Disk size report
Sample | kb/event | ref kb/event | diff |
---|---|---|---|
TTbar MC 102X | 1.829 | 1.831 | -0.002 ( -0.1% ) |
TTbar MC 94Xv1 | 1.922 | 1.924 | -0.002 ( -0.1% ) |
TTbar MC 94Xv2 | 1.956 | 1.956 | -0.001 ( -0.0% ) |
TTbar MC 94X2016 | 1.743 | 1.744 | -0.001 ( -0.1% ) |
TTbar MC 80X | 1.901 | 1.902 | -0.001 ( -0.1% ) |
Data 102X | 0.962 | 0.962 | -0.001 ( -0.1% ) |
Data 94Xv1 | 0.913 | 0.914 | -0.001 ( -0.1% ) |
Data 80X | 0.793 | 0.793 | -0.000 ( -0.0% ) |
Data 80X, Mu Run2016E | 0.774 | 0.775 | -0.001 ( -0.1% ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR updates DeepTauID to ver. 2017v2p1 containing fix which removes big data-MC discrepancy (by disableing usage of dxy_PCA coordinates). In this way DeepTauID ver. 2017v2 added in #388 is superseded.
This PR is inline with cms-sw#27878 to master of official CMSSW and its backport to 10_2_X cms-sw#27879.
The PR is build on top of CMSSW_10_2_X as for 28.08.2019.
PR validation:
Validated with nanoAOD workflow obtained with the following cmsDriver command which corresponds with NanoAODv5:
as well as with its version without
run2_nanoAOD_102Xv1
era specifier.