Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for multi-arch set SCRAM_TARGET to auto MULTIARCH/SKYLAKE otherwise to default #9154

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Apr 24, 2024

This PR contains the following updates

  • For special MULTIARCH/SKYLAKE IB/releases: set SCRAM_TARGET to auto so that scram can automatically select the best set of libraries at runtime. This is what current MULTIARCHS IBs do (so no change in env logic for MULTIARCH/SKYLAKE builds)
  • For default IB with multi-arch support enabled (e.g. 14.1.0.pre3): set SCRAM_TARGET to default so that scram only set default (sse3) set libraries at runtime.
  • SCRAM: Update document about SCRAM_TARGET selection and extra scram help on project specific build targets (cms-sw/SCRAM@f06afeb)
  • Build rules: scram/project/hook has been updated to only enable multi-arch builds in developers' area if release is built with SCRAM_TARGET=auto. With this change, scram will build multi-arch libs for MULTIARCH/SKYLAKE IB/releases but will only build default (sse3) set of libraries for other IBs/releases.

FYI @makortel , @fwyzard

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@cmsbuild, @aandvalenzuela, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_MULTIARCHS_X

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 96c92a7 into IB/CMSSW_14_1_X/master Apr 24, 2024
5 of 6 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc7aa7/39044/summary.html
COMMIT: d28220a
CMSSW: CMSSW_14_1_MULTIARCHS_X_2024-04-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9154/39044/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc7aa7/39044/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc7aa7/39044/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 250 lines from the logs
  • Reco comparison results: 70757 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319852
  • DQMHistoTests: Total failures: 305309
  • DQMHistoTests: Total nulls: 268
  • DQMHistoTests: Total successes: 3014255
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2.0850000000000004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.586 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -2.906 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.043,... ): -0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): -0.070 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): 0.086 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): 0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.836 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.469 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 1.774 KiB SiStrip/MechanicalView
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 18 / 46 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants