-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BrokenLineFit
and RiemannFit
: mask asserts behind DEBUG
flags
#44801
Conversation
cms-bot internal usage |
BrokenLineFits
: mask asserts behind BROKENLINE_DEBUGBrokenLineFits
: mask asserts behind BROKENLINE_DEBUG
flag
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44801/40042
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@mmusich , there is an identical check also in RecoTracker/PixelSeeding/plugins/alpaka/RiemannFit.dev.cc. |
14771cb
to
3c36fcd
Compare
BrokenLineFits
: mask asserts behind BROKENLINE_DEBUG
flagBrokenLineFit
and RiemannFit
: mask asserts behind DEBUG
flags
thanks for the suggestions. All implemented now. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44801/40056
|
Pull request #44801 was updated. @mandrenguyen, @cmsbuild, @jfernan2 can you please check and sign again. |
test parameters:
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-939360/39018/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
urgent |
Why? |
the discussion at #44786 was not yet fully converged. Removed. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fixes #44786.
As described in the issue this will avoid triggering assertion failures on GPU when running the example in #44786 (comment), this - incidentally - is also the status quo on CUDA, see #44786 (comment).
Implements masking assertions behind compilation flag
BROKENLINE_DEBUG
as per #44786 (comment).PR validation:
runs fine in this branch.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, might want to backport to CMSSW_14_0_X for the next online data-taking release.