Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT Menu check for the PCL Tracker Alignment #44783

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

phnattla
Copy link
Contributor

PR description:

Added new option to veto specific run for PCL alignment based on their HLT Menu. Implemented using a new variable veto_HLT_Menu in LSNumberFilter config.
This change was made, since the PCL Alignment triggered an update based on a Lumiscan run (Run 379524, https://cmsoms.cern.ch/cms/runs/report?cms_run=379524).

PR validation:

PR was validated by testing the MilleStep for one nominal run (Run 379530) and the Lumiscan run (Run 379524), using the following command:

cmsDriver.py milleStep -s ALCA:PromptCalibProdSiPixelAli --conditions 140X_dataRun3_Express_v2 --scenario pp --data --era Run3 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100 --dasquery='file dataset=/StreamExpress/Run2024C-TkAlMinBias-Express-v1/ALCARECO run=<379524, 379530>'

@mmusich @dmeuser @henriettepetersen @TomasKello

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Apr 19, 2024

test parameters:

  • workflows = 1001.0, 1001.2, 1001.3, 1001.4, 1002.3

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44783/40019

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @phnattla for master.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)

@consuegs, @cmsbuild, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks.
@tlampen, @adewit, @mmusich, @tocheng, @rsreds, @pakhotin, @yuanchao this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Apr 19, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d07e50/38961/summary.html
COMMIT: 8111271
CMSSW: CMSSW_14_1_X_2024-04-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44783/38961/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3349591
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3349565
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 223 log files, 169 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants