-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
miscellaneous improvements to LSNumberFilter
#44810
miscellaneous improvements to LSNumberFilter
#44810
Conversation
cms-bot internal usage |
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44810/40060
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@cmsbuild, @perrotta, @consuegs, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
-1 Failed Tests: Build ClangBuild The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Leaving Package HeterogeneousCore/ROCmServices >> Package HeterogeneousCore/ROCmServices built Entering library rule at src/HeterogeneousCore/ROCmServices/plugins >> Compiling edm plugin src/HeterogeneousCore/ROCmServices/plugins/ROCmMonitoringService.cc >> Compiling edm plugin src/HeterogeneousCore/ROCmServices/plugins/ROCmService.cc src/HeterogeneousCore/ROCmServices/plugins/ROCmService.cc:9:10: fatal error: rocm-core/rocm_version.h: No such file or directory 9 | #include | ^~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. gmake: *** [tmp/el8_amd64_gcc12/src/HeterogeneousCore/ROCmServices/plugins/HeterogeneousCoreROCmServicesPlugins/ROCmService.cc.o] Error 1 >> Building edm plugin tmp/el8_amd64_gcc12/src/HeterogeneousCore/ROCmServices/plugins/HeterogeneousCoreROCmServicesPlugins/libHeterogeneousCoreROCmServicesPlugins.so Clang BuildI found compilation error while trying to compile with clang. Command used:
>> Entering Package L1Trigger/DemonstratorTools >> Entering Package L1Trigger/L1TCalorimeter >> Entering Package RecoParticleFlow/PFRecHitProducer >> Entering Package Validation/Geometry >> Compile sequence completed for CMSSW CMSSW_14_1_X_2024-04-22-1100 gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1 + eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-22-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)' ++ scram build outputlog >> Entering Package Alignment/CommonAlignmentProducer Entering library rule at src/Alignment/CommonAlignmentProducer/plugins >> Compiling edm plugin src/Alignment/CommonAlignmentProducer/plugins/FakeAlignmentProducer.cc |
@cmsbuild, please test
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2e41e/39038/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Quick followup on top of #44783.
Some miscellaneous improvements to the
LSNumberFilter
(mainly adding afillDescriptions
method and use it for configuring the Tk Al PCL modules).PR validation:
PR was validated by testing the MilleStep for one nominal run (Run 379530) and the Lumiscan run (Run 379524), using the following command:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but will be backported together with #44783 to CMSSW_14_0_X.