Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update root to version 6.26.10+patches #8421

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Apr 3, 2023

backport of #8396

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_0_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2aa2e/31774/summary.html
COMMIT: ff80b75
CMSSW: CMSSW_13_0_X_2023-04-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8421/31774/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2aa2e/31774/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2aa2e/31774/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • You potentially removed 177 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 172 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3553952
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3553914
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Apr 4, 2023

+externals

unit test failure is known issue with root updates and this unit tests. As this tests creates a dev area and then mixes libs from old root and new root.

@perrotta , @rappoccio , following the recommendation here cms-sw/cmssw#41246 (comment) , this backported the latest root 6.26 changes in to 13.0.X. This is ready to go in, feel free to merge it

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link

urgent

  • needed for a 13_0_3 to be used online as soon as possible

@cmsbuild cmsbuild added the urgent label Apr 4, 2023
@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2023

+1

  • According to update root to version 6.26.10+patches #8421 (comment) "unit test failure is known issue with root updates and this unit tests"
  • Let have this merged in 13_0_X, so that we can build a CMSSW_13_0_3 with it if it will be decided so during the joint operation meeting of today

@smuzaffar smuzaffar merged commit b68a811 into IB/CMSSW_13_0_X/master Apr 4, 2023
@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2023

@smuzaffar thank you for merging
I would have done so anyhow before 1100: I was just waiting a bit in case the tests that you launched last would have finished before that. However, I agree with you that we can look at the results of those tests even when this PR is merged.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2aa2e/31777/summary.html
COMMIT: ff80b75
CMSSW: CMSSW_13_0_X_2023-04-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8421/31777/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • You potentially removed 178 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3553952
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3553927
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants