-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update root to version 6.26.10+patches #8421
Conversation
test parameters:
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_0_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
|
please test |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test TestIOPoolInputNoParentDictionary had ERRORS Comparison SummarySummary:
|
please test |
+externals unit test failure is known issue with root updates and this unit tests. As this tests creates a dev area and then mixes libs from old root and new root. @perrotta , @rappoccio , following the recommendation here cms-sw/cmssw#41246 (comment) , this backported the latest root 6.26 changes in to 13.0.X. This is ready to go in, feel free to merge it |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
urgent
|
+1
|
@smuzaffar thank you for merging |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test TestIOPoolInputNoParentDictionary had ERRORS Comparison SummarySummary:
|
backport of #8396