-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BTV] Backport of #40803 (PUPPI ValueMap-compatible Deep taggers info producers) #41210
[BTV] Backport of #40803 (PUPPI ValueMap-compatible Deep taggers info producers) #41210
Conversation
… weighted jets (e.g puppi jets)
…t() function if ValueMap not specified and explicitly asked to use fallback value.
…n when jet is weighted but no ValueMap is set. code-checks formatting.
A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_13_0_X. It involves the following packages:
@swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
FYI @AnnikaStein, @AlexDeMoor and @demuller |
enable nano |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eec2a8/31655/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
backport of #40803 |
type btv |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Backport from #40803
Original PR description:
The main goal of this PR is to modify several BTV Deep taggers info producers, which are used to retrieve the features of each jet , to retrieve the puppi weight for each PF candidate from a
ValueMap<float>
produced byPuppiProducer
. The (fallback) puppi weight value is set to be1.0
before accessing the weight from the ValueMap. If users do not set thefallback_puppi_weight
flag to betrue
and does not specify a source forpuppi_value_map
, an exception is thrown. A new optional flagis_weighted_jet
is introduced so that users can make specify to apply the puppi weights on the PF constituents' four-vector. The flag should be set totrue
for Puppi jets.A new function,
setupPackedPuppi()
, is defined inPhysicsTools/PatAlgos/python/tools/jetTools.py
that can be called to setup aPuppiProducer
instance and provides a common puppi weight ValueMap for any module which requires one.PR validation:
runTheMatrix.py -l limited -i all --ibeos
runTheMatrix.py -i all --ibeos -l 10224.15,11024.15,25202.15,11634.15
runTheMatrix.py -i all --ibeos -l 1325.518,2500.312