Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BTV] Backport of #40803 (PUPPI ValueMap-compatible Deep taggers info producers) #41210

Conversation

nurfikri89
Copy link
Contributor

Backport from #40803

Original PR description:

The main goal of this PR is to modify several BTV Deep taggers info producers, which are used to retrieve the features of each jet , to retrieve the puppi weight for each PF candidate from a ValueMap<float> produced by PuppiProducer. The (fallback) puppi weight value is set to be 1.0 before accessing the weight from the ValueMap. If users do not set the fallback_puppi_weight flag to be true and does not specify a source for puppi_value_map, an exception is thrown. A new optional flag is_weighted_jet is introduced so that users can make specify to apply the puppi weights on the PF constituents' four-vector. The flag should be set to true for Puppi jets.

A new function, setupPackedPuppi(), is defined in PhysicsTools/PatAlgos/python/tools/jetTools.py that can be called to setup a PuppiProducer instance and provides a common puppi weight ValueMap for any module which requires one.

PR validation:

  • Validation plots comparing the input variables before and after the fix can be found in this JMAR meeting virtual contribution.
  • passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos
  • passes JMENanoAOD workflows: runTheMatrix.py -i all --ibeos -l 10224.15,11024.15,25202.15,11634.15
  • passes reMiniAOD and reNanoAOD workflows: runTheMatrix.py -i all --ibeos -l 1325.518,2500.312

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 28, 2023

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_13_0_X.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)
  • RecoBTag/FeatureTools (reconstruction)

@swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @mbluj, @demuller, @seemasharmafnal, @mmarionncern, @missirol, @ahinzmann, @jdolen, @azotz, @hqucms, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @AlexDeMoor, @AnnikaStein, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@nurfikri89
Copy link
Contributor Author

FYI @AnnikaStein, @AlexDeMoor and @demuller

@simonepigazzini
Copy link
Contributor

enable nano

@simonepigazzini
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eec2a8/31655/summary.html
COMMIT: caf3ca4
CMSSW: CMSSW_13_0_X_2023-03-28-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41210/31655/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 171 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554479
  • DQMHistoTests: Total failures: 18
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554439
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 10777
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 10777
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.223 2.223 0.000 ( +0.0% ) 9.44 9.67 -2.3% 1.405 1.511
2500.311 2.322 2.322 0.000 ( +0.0% ) 9.06 9.22 -1.7% 1.735 1.885
2500.312 2.275 2.275 0.000 ( +0.0% ) 9.22 9.45 -2.5% 1.730 1.875
2500.33 1.098 1.098 0.000 ( +0.0% ) 21.62 22.23 -2.7% 1.449 1.640
2500.331 1.392 1.392 0.000 ( +0.0% ) 15.57 16.17 -3.7% 1.616 1.791
2500.332 1.324 1.324 0.000 ( +0.0% ) 17.61 18.31 -3.8% 1.538 1.829
2500.401 2.137 2.137 0.000 ( +0.0% ) 10.48 10.52 -0.4% 1.085 1.205
2500.501 1.710 1.710 0.000 ( +0.0% ) 16.70 16.78 -0.5% 1.041 1.129
2500.511 1.122 1.122 0.000 ( +0.0% ) 31.31 31.17 +0.4% 1.284 1.373
2500.601 2.049 2.049 0.000 ( +0.0% ) 12.55 12.59 -0.3% 1.025 1.182

@mandrenguyen
Copy link
Contributor

backport of #40803

@mandrenguyen
Copy link
Contributor

type btv

@cmsbuild cmsbuild added the btv label Mar 29, 2023
@mandrenguyen
Copy link
Contributor

+1

@simonepigazzini
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cde8885 into cms-sw:CMSSW_13_0_X Apr 3, 2023
@nurfikri89 nurfikri89 deleted the portFrom131XTo130X_btv_puppiValueMapForMini branch June 7, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants