add track algo and originalAlgo to PackedCandidates [13_0_X]

[slava77]

backport of #41183 (the same topic branch is used)

This PR adds track algo and originalAlgo to PackedCandidates as uint8_t data members; the values are filled with the same selections as other track properties (mainly driven by pt> minPtForTrackProp, the cut is at 0.95 GeV)

The primary use case so far is in the tag-and-probe measurements of tracking performance where general and muon tracking iterations need to be separated and the analysis is forced to use AOD, while a switch to miniAOD should be possible.

More use cases can arise for improved track quality selection and lower level debugging in miniAOD.

Tested in CMSSW_13_0_0_pre4 on /store/relval/CMSSW_13_0_0_pre4/RelValTTbar_14TeV/GEN-SIM-RECO/PU_130X_mcRun3_2022_realistic_v2-v2/00000/{08b3cb94-2a3e-42c8-9374-46b4264dbef7.root,1a2b2a1d-133a-435c-b275-a4e3b651e71c.root,50823067-81cd-459a-baf7-aabc7851cce5.root,902c1d68-aa8e-49ea-94df-228edecdd3e9.root} with 4000 events running PAT step (step4 from wf 11834.21).

• the sum of all products (using edmEventSize) compressed size increases by 238 B/ev or 0.27%
• The packedPFCandidates collection size increases by 0.5% or 205 B/event (from 43.3 kiB/ev)

This was proposed to XPOG in the Jan 25 meeting (before the code was implemented and consequently before the file size measurements mentioned above)

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_13_0_X.

It involves the following packages:

• DataFormats/PatCandidates (xpog, reconstruction)
• PhysicsTools/PatAlgos (xpog, reconstruction)
• RecoBTag/FeatureTools (reconstruction)

@swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @mbluj, @demuller, @seemasharmafnal, @mmarionncern, @missirol, @ahinzmann, @jdolen, @azotz, @hqucms, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @AlexDeMoor, @AnnikaStein, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from add track algo and originalAlgo to PackedCandidates #41183

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6f65c/31684/summary.html
COMMIT: 1e3b629
CMSSW: CMSSW_13_0_X_2023-03-29-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41227/31684/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3554479
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554457
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mbluj]

Hi, maybe it is my ignorance, but not ioread rules are needed to read older version of PackedCandidate? Or it will work fine as 0 will be returned in case of access to the missing data-member trkAlgoPacked_?

[slava77]

Hi, maybe it is my ignorance, but not ioread rules are needed to read older version of PackedCandidate? Or it will work fine as 0 will be returned in case of access to the missing data-member trkAlgoPacked_?

default value should be assigned to all new values. I can't recall if it technically happens because a default constructor is called first for in-memory objects before doing assignments from file.

[mandrenguyen]

backport of #41183

[mandrenguyen]

type tracking

[mandrenguyen]

+1

[vlimant]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1