Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT6] Updated root to tip of branch master #8312

Conversation

aandvalenzuela
Copy link
Contributor

No news on #8289.
But let's run the tests just in case it is fixed.

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_13_1_X/rootmaster.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c2cf9/30616/summary.html
COMMIT: be2cbe8
CMSSW: CMSSW_13_1_ROOT6_X_2023-02-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8312/30616/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

#63 0x00002afae51840fd in WrapperCall (method=47257073078325, nargs=140726133274800, args_=0x7ffd5b2f3860, self=0x7ffd5b2f3850, result=0x7ffd5b2f3848) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/lcg/root/6.29.01-0801b3cc330d6ebd235654131310dec3/root-6.29.01/bindings/pyroot/cppyy/cppyy-backend/clingwrapper/src/clingwrapper.cxx:774
===========================================================


Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/BTauReco/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/el8_amd64_gcc11/edm_checks/libDataFormatsBTauReco.so] Error 1
>> Checking EDM Class Version for src/DataFormats/ForwardDetId/src/classes_def.xml in libDataFormatsForwardDetId.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsFTLDigi.so
@@@@ ----> OK  EDM Class Version 
@@@@ ----> OK  EDM Class Version 


@iarspider
Copy link
Contributor

test parameters:

  • full_cmssw = true

@iarspider
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c2cf9/30626/summary.html
COMMIT: be2cbe8
CMSSW: CMSSW_13_1_ROOT6_X_2023-02-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8312/30626/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c2cf9/30626/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c2cf9/30626/git-merge-result

Build

I found compilation error when building:

>> Checking EDM Class Transients in libDataFormatsCSCRecHit.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsCTPPSDigi.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsBeamSpot.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/lcg/root/6.29.01-0801b3cc330d6ebd235654131310dec3/etc/cling/std.modulemap:497:10: error: module 'std.bits/uses_allocator_args.h' requires feature 'cplusplus20'
  module "bits/uses_allocator_args.h" {
         ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/include/c++/11.2.1/memory_resource:42:10: note: submodule of top-level module 'std' implicitly imported here
#include    // uninitialized_construct_using_alloc
         ^


@iarspider
Copy link
Contributor

Waiting for ROOT fix: root-project/root#12240

@iarspider iarspider closed this Feb 14, 2023
@iarspider iarspider reopened this Feb 15, 2023
@iarspider
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Pull request #8312 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c2cf9/30645/summary.html
COMMIT: 2473822
CMSSW: CMSSW_13_1_ROOT6_X_2023-02-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8312/30645/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8312 was updated.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c2cf9/30647/summary.html
COMMIT: 0915e65
CMSSW: CMSSW_13_1_ROOT6_X_2023-02-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8312/30647/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c2cf9/30647/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c2cf9/30647/git-merge-result

Build

I found compilation error when building:

>> Checking EDM Class Transients in libDataFormatsCTPPSDigi.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsBeamSpot.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsCTPPSReco.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/lcg/root/6.29.01-d211d0de98c4c1d92aca13cfeb930afd/etc/cling/std.modulemap:497:10: error: module 'std.bits/uses_allocator_args.h' requires feature 'cplusplus20'
  module "bits/uses_allocator_args.h" {
         ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/include/c++/11.2.1/memory_resource:42:10: note: submodule of top-level module 'std' implicitly imported here
#include    // uninitialized_construct_using_alloc
         ^


@aandvalenzuela
Copy link
Contributor Author

Same error. Waiting for root-project/root#12240

@smuzaffar
Copy link
Contributor

@aandvalenzuela , looks like the patch here is not complete, can you please update it https://patch-diff.githubusercontent.com/raw/root-project/root/pull/12276.patch and restart the tests?

@cmsbuild
Copy link
Contributor

Pull request #8312 was updated.

@aandvalenzuela
Copy link
Contributor Author

please test

@aandvalenzuela
Copy link
Contributor Author

Now it built!
FYI, @smuzaffar, @iarspider

@davidlange6
Copy link
Contributor

davidlange6 commented Feb 16, 2023 via email

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c2cf9/30658/summary.html
COMMIT: 3722765
CMSSW: CMSSW_13_1_ROOT6_X_2023-02-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8312/30658/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c2cf9/30658/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c2cf9/30658/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_occi_std_length had ERRORS

Comparison Summary

Summary:

  • You potentially removed 152 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3556272
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3556247
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

lets wait for root-project/root#12276 to go in and then update root master to use the latest commit.

By the way, in future if you have to test a root PR then instead of including patch just use root's user branch e.g. in this case https://github.com/vgvassilev/root/tree/cxxmodules-gcc11 adn open cms-sw/root PR ( usign the root commit branch) and then test it directly from cms-sw/root repo :-)

@aandvalenzuela
Copy link
Contributor Author

Update of root master with the tested patch at #8320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants