-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only compare geometry in Geometry/TrackerGoeometryBuilder test #40757
Only compare geometry in Geometry/TrackerGoeometryBuilder test #40757
Conversation
Removed inclusion of SimpleMemoryCheck and Timing service in the test to avoid those causing non-geometry related failures.
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40757/34174
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@makortel, @bsunanda, @civanch, @Dr15Jones, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-297c3a/30611/summary.html Comparison SummarySummary:
|
+geometry |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Thank you @Dr15Jones |
PR description:
Removed inclusion of SimpleMemoryCheck and Timing service in the test to avoid those causing non-geometry related failures.
The test was previously failing because of a change to the output of SimpleMemoryCheck.
PR validation:
The unit test now passes.