Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only compare geometry in Geometry/TrackerGoeometryBuilder test #40757

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Removed inclusion of SimpleMemoryCheck and Timing service in the test to avoid those causing non-geometry related failures.

The test was previously failing because of a change to the output of SimpleMemoryCheck.

PR validation:

The unit test now passes.

Removed inclusion of SimpleMemoryCheck and Timing service in
the test to avoid those causing non-geometry related failures.
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40757/34174

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • Geometry/TrackerGeometryBuilder (geometry)

@makortel, @bsunanda, @civanch, @Dr15Jones, @mdhildreth can you please review it and eventually sign? Thanks.
@VourMa, @JanFSchulte, @VinInn, @bsunanda, @mmusich, @mtosi, @fabiocos, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-297c3a/30611/summary.html
COMMIT: 10cade8
CMSSW: CMSSW_13_1_X_2023-02-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40757/30611/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555972
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555950
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor

+geometry

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

Thank you @Dr15Jones
I cherry-picked your commit a made a backport for 13_0_X in #40759

@Dr15Jones Dr15Jones deleted the fixUnitTestGeometry_TrackerGeometryBuilder branch February 15, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants