[cxxmodules] Add a module for experimental/string_view #12276

vgvassilev · 2023-02-09T17:47:35Z

That should fix a recent nightly failure with gcc11

phsft-bot · 2023-02-09T17:47:42Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-02-09T18:18:20Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-02-09T18:18:17.561Z] FAILED: core/G__Core.cxx lib/Core.pcm
[2023-02-09T18:18:19.458Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/std.modulemap:495:12: error: header 'bits/ranges_base.h' not found
[2023-02-09T18:18:19.458Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/std.modulemap:495:12: error: header 'bits/ranges_base.h' not found
[2023-02-09T18:18:19.458Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/Interpreter/DynamicExprInfo.h:40:7: error: use of undeclared identifier 'std'
[2023-02-09T18:18:19.458Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/std.modulemap:495:12: error: header 'bits/ranges_base.h' not found
[2023-02-09T18:18:19.458Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/Interpreter/DynamicLookupLifetimeHandler.h:56:7: error: use of undeclared identifier 'std'
[2023-02-09T18:18:19.458Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/std.modulemap:495:12: error: header 'bits/ranges_base.h' not found
[2023-02-09T18:18:19.458Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/Interpreter/Value.h:152:23: error: use of undeclared identifier 'uintptr_t'
[2023-02-09T18:18:19.458Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/Interpreter/Value.h:166:24: error: use of undeclared identifier 'uintptr_t'
[2023-02-09T18:18:19.458Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/Interpreter/Value.h:313:25: error: use of undeclared identifier 'uintptr_t'

And 25 more

phsft-bot · 2023-02-09T19:07:58Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2023-02-09T19:05:42.719Z] /data/sftnight/workspace/root-pullrequests-build/build/etc/cling/std.modulemap:495:12: error: header 'bits/ranges_base.h' not found
[2023-02-09T19:05:42.719Z] /data/sftnight/workspace/root-pullrequests-build/build/etc/cling/std.modulemap:495:12: error: header 'bits/ranges_base.h' not found
[2023-02-09T19:05:42.719Z] /data/sftnight/workspace/root-pullrequests-build/build/etc/cling/Interpreter/DynamicExprInfo.h:40:7: error: use of undeclared identifier 'std'
[2023-02-09T19:05:42.719Z] /data/sftnight/workspace/root-pullrequests-build/build/etc/cling/std.modulemap:495:12: error: header 'bits/ranges_base.h' not found
[2023-02-09T19:05:42.719Z] /data/sftnight/workspace/root-pullrequests-build/build/etc/cling/Interpreter/DynamicLookupLifetimeHandler.h:56:7: error: use of undeclared identifier 'std'
[2023-02-09T19:05:42.719Z] /data/sftnight/workspace/root-pullrequests-build/build/etc/cling/std.modulemap:495:12: error: header 'bits/ranges_base.h' not found
[2023-02-09T19:05:42.719Z] /data/sftnight/workspace/root-pullrequests-build/build/etc/cling/Interpreter/Value.h:152:23: error: use of undeclared identifier 'uintptr_t'
[2023-02-09T19:05:42.719Z] /data/sftnight/workspace/root-pullrequests-build/build/etc/cling/Interpreter/Value.h:166:24: error: use of undeclared identifier 'uintptr_t'
[2023-02-09T19:05:42.720Z] /data/sftnight/workspace/root-pullrequests-build/build/etc/cling/Interpreter/Value.h:313:25: error: use of undeclared identifier 'uintptr_t'
[2023-02-09T19:05:42.720Z] /data/sftnight/workspace/root-pullrequests-build/build/etc/cling/Interpreter/RuntimeUniverse.h:27:10: fatal error: could not build module 'Cling_Runtime_Extra'

And 24 more

phsft-bot · 2023-02-09T20:15:03Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-02-09T20:15:02.389Z] FAILED: core/G__Core.cxx lib/Core.pcm
[2023-02-09T20:15:02.390Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/std.modulemap:495:12: error: header 'bits/ranges_base.h' not found
[2023-02-09T20:15:02.390Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/std.modulemap:495:12: error: header 'bits/ranges_base.h' not found
[2023-02-09T20:15:02.390Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/Interpreter/DynamicExprInfo.h:40:7: error: use of undeclared identifier 'std'
[2023-02-09T20:15:02.390Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/std.modulemap:495:12: error: header 'bits/ranges_base.h' not found
[2023-02-09T20:15:02.390Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/Interpreter/DynamicLookupLifetimeHandler.h:56:7: error: use of undeclared identifier 'std'
[2023-02-09T20:15:02.390Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/std.modulemap:495:12: error: header 'bits/ranges_base.h' not found
[2023-02-09T20:15:02.390Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/Interpreter/Value.h:152:23: error: use of undeclared identifier 'uintptr_t'
[2023-02-09T20:15:02.390Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/Interpreter/Value.h:166:24: error: use of undeclared identifier 'uintptr_t'
[2023-02-09T20:15:02.390Z] /home/sftnight/build/workspace/root-pullrequests-build/build/etc/cling/Interpreter/Value.h:313:25: error: use of undeclared identifier 'uintptr_t'

And 25 more

phsft-bot · 2023-02-10T17:19:19Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

pcanal

Could enhance the commit log by copy/pasting/summarizing the error that it fixes? The log will be long gone when we next look at that commit log. Thanks.

vgvassilev · 2023-02-12T19:35:36Z

The commit message seems pretty clear to me. Can you suggest something?

Axel-Naumann · 2023-02-13T08:00:48Z

@pcanal proposes to add the literal diagnostic, which helps understand "recent failure" in two years, and which allows to search if we run into this again, e.g. in 6-26:

[ 70%] Generating G__Core.cxx, ../lib/Core.pcm

/home/sftnight/build/night/LABEL/ROOT-fedora36/SPEC/default/V/master/build/etc/cling/std.modulemap:491:10: error: module 'std.bits/ranges_base.h' requires feature 'cplusplus20'
  module "bits/ranges_base.h" {
         ^
/usr/include/c++/12/experimental/string_view:43:10: note: submodule of top-level module 'std' implicitly imported here
#include <bits/ranges_base.h> // enable_borrowed_range, enable_view
         ^
In file included from input_line_3:2:

/home/sftnight/build/night/LABEL/ROOT-fedora36/SPEC/default/V/master/build/include/Rtypes.h:195:10: fatal error: could not build module 'ROOT_Foundation_Stage1_NoRTTI'
#include "TIsAProxy.h"
 ~~~~~~~~^~~~~~~~~~~~~

Error: Error loading the default rootcling header files.
gmake[2]: *** [core/CMakeFiles/G__Core.dir/build.make:474: core/G__Core.cxx] Error 1

Axel-Naumann · 2023-02-13T11:56:26Z

(And btw it's GCC 12, I'm not remembering seeing this issue with GCC 11 as the commit log says?)

vgvassilev · 2023-02-14T07:04:17Z

(And btw it's GCC 12, I'm not remembering seeing this issue with GCC 11 as the commit log says?)

Nope, the problem being fixed is seen for gcc11 as the commit message points out: https://lcgapp-services.cern.ch/root-jenkins/view/ROOT%20Nightly/job/root-nightly-master/LABEL=ROOT-centos9,SPEC=noimt,V=master/3429/console

vgvassilev · 2023-02-14T07:06:53Z

@pcanal proposes to add the literal diagnostic, which helps understand "recent failure" in two years, and which allows to search if we run into this again, e.g. in 6-26:

[ 70%] Generating G__Core.cxx, ../lib/Core.pcm

/home/sftnight/build/night/LABEL/ROOT-fedora36/SPEC/default/V/master/build/etc/cling/std.modulemap:491:10: error: module 'std.bits/ranges_base.h' requires feature 'cplusplus20'
  module "bits/ranges_base.h" {
         ^
/usr/include/c++/12/experimental/string_view:43:10: note: submodule of top-level module 'std' implicitly imported here
#include <bits/ranges_base.h> // enable_borrowed_range, enable_view
         ^
In file included from input_line_3:2:

/home/sftnight/build/night/LABEL/ROOT-fedora36/SPEC/default/V/master/build/include/Rtypes.h:195:10: fatal error: could not build module 'ROOT_Foundation_Stage1_NoRTTI'
#include "TIsAProxy.h"
 ~~~~~~~~^~~~~~~~~~~~~

Error: Error loading the default rootcling header files.
gmake[2]: *** [core/CMakeFiles/G__Core.dir/build.make:474: core/G__Core.cxx] Error 1

The commit message says exactly that. I don't think I want to paste the error to say actually the same thing as the commit message says.

phsft-bot · 2023-02-14T07:10:14Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

vgvassilev · 2023-02-14T07:10:37Z

@pcanal proposes to add the literal diagnostic, which helps understand "recent failure" in two years, and which allows to search if we run into this again, e.g. in 6-26:

[ 70%] Generating G__Core.cxx, ../lib/Core.pcm

/home/sftnight/build/night/LABEL/ROOT-fedora36/SPEC/default/V/master/build/etc/cling/std.modulemap:491:10: error: module 'std.bits/ranges_base.h' requires feature 'cplusplus20'
  module "bits/ranges_base.h" {
         ^
/usr/include/c++/12/experimental/string_view:43:10: note: submodule of top-level module 'std' implicitly imported here
#include <bits/ranges_base.h> // enable_borrowed_range, enable_view
         ^
In file included from input_line_3:2:

/home/sftnight/build/night/LABEL/ROOT-fedora36/SPEC/default/V/master/build/include/Rtypes.h:195:10: fatal error: could not build module 'ROOT_Foundation_Stage1_NoRTTI'
#include "TIsAProxy.h"
 ~~~~~~~~^~~~~~~~~~~~~

Error: Error loading the default rootcling header files.
gmake[2]: *** [core/CMakeFiles/G__Core.dir/build.make:474: core/G__Core.cxx] Error 1

The commit message says exactly that. I don't think I want to paste the error to say actually the same thing as the commit message says.

I think I see where the confusion comes from, now. I added the PR title in the commit message.

Axel-Naumann · 2023-02-14T07:24:31Z

Yes, better than the "That should fix a recent nightly failure with gcc11" that Philippe commented on, thanks for improving it!

Compared to just including the actual diagnostic (something Philippe and I generally try to do these days, something that has proven super helpful several times), your current log:

That should fix a recent nightly failure with gcc11 avoiding to require
module "bits/ranges_base.h" in C++20 context.

does not call out

that it's during dictionary generation
that the modulemap requires the module feature 'cplusplus20' (your log seems to suggest that the error surfaces when compiled in C++20 mode, while this error shows up when compiling in C++14 or 17)
that the issue is also with GCC12 headers (your message seems to suggest that it's only with GCC11 headers)
the "stack trace", i.e. /usr/include/c++/12/experimental/string_view:43:10: note: submodule of top-level module 'std' implicitly imported here and then /home/sftnight/build/night/LABEL/ROOT-fedora36/SPEC/default/V/master/build/include/Rtypes.h:195:10: fatal error: could not build module 'ROOT_Foundation_Stage1_NoRTTI' and then #include "TIsAProxy.h"

In general we tell our users (+/- always) "can we please see the actual diagnostic", and for the same reasons it's super helpful to include them here. The time we discussed this is waaay larger than the time it would have taken you to update the log to what Philippe proposes, rather than updating it to something that tries to address the issues (but seemingly fails?)

But it's Philippe's review, I let him comment / deal with this if you still prefer to keep your current commit log. I simply wanted to add an explanation why Philippe suggests the inclusion of the actual diagnostic (and why I found it convincing and do it ever since he propose it to me).

vgvassilev · 2023-02-14T16:21:48Z

Yes, better than the "That should fix a recent nightly failure with gcc11" that Philippe commented on, thanks for improving it!

Compared to just including the actual diagnostic (something Philippe and I generally try to do these days, something that has proven super helpful several times), your current log:
That should fix a recent nightly failure with gcc11 avoiding to require
module "bits/ranges_base.h" in C++20 context.
does not call out
* that it's during dictionary generation

* that the modulemap requires the module feature 'cplusplus20' (your log seems to suggest that the error surfaces when compiled in C++20 mode, while this error shows up when compiling in C++14 or 17)

* that the issue is also with GCC12 headers (your message seems to suggest that it's only with GCC11 headers)

* the "stack trace", i.e. `/usr/include/c++/12/experimental/string_view:43:10: note: submodule of top-level module 'std' implicitly imported here` and then `/home/sftnight/build/night/LABEL/ROOT-fedora36/SPEC/default/V/master/build/include/Rtypes.h:195:10: fatal error: could not build module 'ROOT_Foundation_Stage1_NoRTTI'` and then `#include "TIsAProxy.h"`
In general we tell our users (+/- always) "can we please see the actual diagnostic", and for the same reasons it's super helpful to include them here. The time we discussed this is waaay larger than the time it would have taken you to update the log to what Philippe proposes, rather than updating it to something that tries to address the issues (but seemingly fails?)

But it's Philippe's review, I let him comment / deal with this if you still prefer to keep your current commit log. I simply wanted to add an explanation why Philippe suggests the inclusion of the actual diagnostic (and why I found it convincing and do it ever since he propose it to me).

This issue exists on gcc11 and gcc12 (and I guess any gcc that made changes to libstdc++ and the experimental/string_view header file). I am not sure if pasting a diagnostic from a random system makes this clearer in any form. I agree with you this should have be 1 min review fixing an important failure that we introduced with the c++20 support and some of the new releases of maybe libstdc++.

@pcanal I find pasting errors in the logs a bad practice, especially when it obfuscates the real fix. Can you suggest a commit message which adds enough information which makes me happy as well?

In general it is a bit unfortunate how the whole review went for this PR. This should been just a simple "approve" as I thought we needed a quick fix which I developed in between travels and a business trip... I suspect this would help me define urgent/important in similar circumstances in future...

pcanal · 2023-02-14T20:22:22Z

@vgvassilev Let me clarify the disconnect.

The title says "Add a module for experimental/string_view"
The commit says:

That should fix a recent nightly failure with gcc11 avoiding to require
module "bits/ranges_base.h" in C++20 context.

The code says:

 module "experimental/string_view" {
    export *
    header "experimental/algorithm"
 }

The commit content as-is seems completely unrelated to the commit log as far as I could tell (without doing research on the relationship between range_base, string_view and algorithm.

So I pondered whether the fix was the right fix for a problem I did not know anything about ...

The right thing to do would have probably be have been to request a complete explanation of what the original problem was, what was the mechanism leading to the error and why this solution was the best solution.

This was obviously much more than this seemingly simple fix required.

So instead I thought to ask for a very low cost, straight forward solution: simply copy/pasting the error with no additional effort to explain in detail.

Can you suggest a commit message which adds enough information which makes me happy as well?

That requires to paraphrase the error and add a few more details.

That should fix a recent nightly failure with gcc11.

The failure presented during dictionary generation in a C++14 and C++17 build and incorrectly complained about needing   the 'cplusplus20' feature for the 'std.bits/ranges_base.h' module.  The issue was triggered by an inclusion of `<bits/ranges_base.h>`  from `string_view`.

This issue exists on gcc11 and gcc12 (and I guess any gcc that made changes to libstdc++ and the experimental/string_view header file). 

It seems the issue is solved by exporting `algorithm` as part of the `string_view` module.

Actually, I still don't know why adding algorithm fixes a problem with range_base.h, so I can't add that to the commit ... maybe it is something like "... by avoiding to use the module maps provided by the standard library in those case"?

vgvassilev · 2023-02-14T22:09:01Z

Actually, I still don't know why adding algorithm fixes a problem with range_base.h, so I can't add that to the commit ... maybe it is something like "... by avoiding to use the module maps provided by the standard library in those case"?

Now that’s something I was looking for! Thank you! I think that’s a mistake in this PR. I failed to update the relevant header as well. The problem is more subtle probably as since some update of gcc it started picking up experimental/string_view which in turn somehow uses the headers only available in c++14 onwards. So perhaps we should re-export string_view… I can look at that tomorrow.

phsft-bot · 2023-02-15T07:38:56Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-02-15T09:59:51Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

vgvassilev · 2023-02-15T10:00:11Z

@pcanal, please check the commit log, I think that's good to go.

pcanal

Looks sufficient even-though the wording still leaves me a bit confused.

it needs to include "bits/ranges_base.h" which is a c++14 header

Then why is the error message talking about require C++20 context?

breaks the compilation in case of c++11.

Didn't Axel report that it failed in C++14 and C++17?

phsft-bot · 2023-02-16T07:04:34Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-02-16T17:16:42Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-02-16T17:23:16Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-02-16T17:52:44Z

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.test.test_stressgraphics_interpreted

phsft-bot · 2023-02-16T17:54:32Z

Build failed on mac12/noimt.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.test.test_stressgraphics_interpreted

phsft-bot · 2023-02-16T18:00:17Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-02-16T18:32:09Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.test.test_stressgraphics_interpreted

phsft-bot · 2023-02-16T19:22:19Z

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

Recent gcc updates somehow make experimental/string_view available through module string_view. Then it wrongly decides it needs to include "bits/ranges_base.h" which is a c++14 header and breaks the compilation in case of c++11. This patch adds a proper experimental/string_view to disallow such shadowing.

It is not present on some versions of libstdc++ which makes the compilation of Core.pcm fail.

phsft-bot · 2023-02-16T19:39:56Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-02-16T20:07:32Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.test.test_stressgraphics_interpreted

phsft-bot · 2023-02-16T20:10:05Z

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.test.test_stressgraphics_interpreted

phsft-bot · 2023-02-16T20:11:48Z

Build failed on mac12/noimt.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-02-16T20:12:22Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-02-16T21:10:29Z

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-02-16T21:47:22Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.test.test_stressgraphics_interpreted

phsft-bot · 2023-02-16T22:37:16Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

And 201 more

vgvassilev · 2023-02-17T07:27:41Z

@phsft-bot build!

phsft-bot · 2023-02-17T07:27:47Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-02-17T07:55:47Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.test.test_stressgraphics_interpreted

phsft-bot · 2023-02-17T07:59:55Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-02-17T08:01:21Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.test.test_stressgraphics_interpreted

phsft-bot · 2023-02-17T08:05:09Z

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.test.test_stressgraphics_interpreted

phsft-bot · 2023-02-17T08:30:40Z

Build failed on mac12/noimt.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.test.test_stressgraphics_interpreted

phsft-bot · 2023-02-17T08:55:29Z

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

vgvassilev · 2023-02-17T09:11:47Z

The failures seem unrelated. Let's merge this PR.

vgvassilev requested a review from Axel-Naumann as a code owner February 9, 2023 17:47

vgvassilev force-pushed the cxxmodules-gcc11 branch from cbeb761 to 4a2920b Compare February 10, 2023 17:19

pcanal requested changes Feb 12, 2023

View reviewed changes

lmoneta assigned vgvassilev Feb 12, 2023

vgvassilev changed the title ~~[cxxmodules] Allow bits/ranges_base.h in c++14 context.~~ [cxxmodules] Add a module for experimental/string_view Feb 14, 2023

vgvassilev force-pushed the cxxmodules-gcc11 branch from 4a2920b to a1a1804 Compare February 14, 2023 07:10

vgvassilev force-pushed the cxxmodules-gcc11 branch from a1a1804 to 8097eac Compare February 15, 2023 07:38

vgvassilev force-pushed the cxxmodules-gcc11 branch from 8097eac to f945434 Compare February 15, 2023 09:59

vgvassilev mentioned this pull request Feb 15, 2023

[ROOT 6.29] module 'std.bits/uses_allocator_args.h' requires feature 'cplusplus20' #12240

Closed

1 task

pcanal approved these changes Feb 15, 2023

View reviewed changes

vgvassilev added 2 commits February 16, 2023 19:39

Remove the problematic uses_allocator_args.h

e4122e8

It is not present on some versions of libstdc++ which makes the compilation of Core.pcm fail.

vgvassilev force-pushed the cxxmodules-gcc11 branch from ae9c66a to e4122e8 Compare February 16, 2023 19:39

smuzaffar mentioned this pull request Feb 16, 2023

[ROOT6] Updated root to tip of branch master cms-sw/cmsdist#8312

Closed

vgvassilev merged commit ac30be3 into root-project:master Feb 17, 2023

vgvassilev deleted the cxxmodules-gcc11 branch February 17, 2023 09:12

[cxxmodules] Add a module for experimental/string_view #12276

[cxxmodules] Add a module for experimental/string_view #12276

Conversation

vgvassilev commented Feb 9, 2023

phsft-bot commented Feb 9, 2023

phsft-bot commented Feb 9, 2023

Errors:

phsft-bot commented Feb 9, 2023

Errors:

phsft-bot commented Feb 9, 2023

Errors:

phsft-bot commented Feb 10, 2023

pcanal left a comment

Choose a reason for hiding this comment

vgvassilev commented Feb 12, 2023

Axel-Naumann commented Feb 13, 2023

Axel-Naumann commented Feb 13, 2023

vgvassilev commented Feb 14, 2023

vgvassilev commented Feb 14, 2023

phsft-bot commented Feb 14, 2023

vgvassilev commented Feb 14, 2023

Axel-Naumann commented Feb 14, 2023 • edited Loading

vgvassilev commented Feb 14, 2023

pcanal commented Feb 14, 2023

vgvassilev commented Feb 14, 2023

phsft-bot commented Feb 15, 2023

phsft-bot commented Feb 15, 2023

vgvassilev commented Feb 15, 2023

pcanal left a comment • edited Loading

Choose a reason for hiding this comment

phsft-bot commented Feb 16, 2023

phsft-bot commented Feb 16, 2023

phsft-bot commented Feb 16, 2023

phsft-bot commented Feb 16, 2023

Failing tests:

phsft-bot commented Feb 16, 2023

Failing tests:

phsft-bot commented Feb 16, 2023

Failing tests:

phsft-bot commented Feb 16, 2023

Failing tests:

phsft-bot commented Feb 16, 2023

Failing tests:

phsft-bot commented Feb 16, 2023

phsft-bot commented Feb 16, 2023

Failing tests:

phsft-bot commented Feb 16, 2023

Failing tests:

phsft-bot commented Feb 16, 2023

Failing tests:

phsft-bot commented Feb 16, 2023

Failing tests:

phsft-bot commented Feb 16, 2023

Failing tests:

phsft-bot commented Feb 16, 2023

Failing tests:

phsft-bot commented Feb 16, 2023

Failing tests:

vgvassilev commented Feb 17, 2023

phsft-bot commented Feb 17, 2023

phsft-bot commented Feb 17, 2023

Failing tests:

phsft-bot commented Feb 17, 2023

Failing tests:

phsft-bot commented Feb 17, 2023

Failing tests:

phsft-bot commented Feb 17, 2023

Failing tests:

phsft-bot commented Feb 17, 2023

Failing tests:

phsft-bot commented Feb 17, 2023

Failing tests:

vgvassilev commented Feb 17, 2023

Axel-Naumann commented Feb 14, 2023 •

edited

Loading

pcanal left a comment •

edited

Loading