Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpaka-related updates #40771

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Alpaka-related updates #40771

merged 4 commits into from
Feb 15, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 15, 2023

PR description:

Various Alpaka-related updates:

  • move HeterogeneousCore/AlpakaCore/interface/MakerMacros.h under alpaka/
  • rename alpaka_hip_async to alpaka_rocm_async
  • adopt the "alternative module loading" approach in the Alpaka test

PR validation:

All unit tests should pass.

PR backport:

To be backported to CMSSW_13_0_X for 2023 data taking.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 15, 2023

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 15, 2023

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 15, 2023

@makortel this is a subset of #40725, hopefully without any controversial parts.

@fwyzard fwyzard force-pushed the Alpaka_updates_13.0.x branch from 6dcca0a to 3cd90b2 Compare February 15, 2023 00:15
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 15, 2023

enable gpu

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40771/34188

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 15, 2023

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • FWCore/ParameterSet (core)
  • HeterogeneousCore/AlpakaCore (heterogeneous)
  • HeterogeneousCore/AlpakaInterface (heterogeneous)
  • HeterogeneousCore/AlpakaTest (heterogeneous)

@makortel, @smuzaffar, @Dr15Jones, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c079fe/30636/summary.html
COMMIT: 3cd90b2
CMSSW: CMSSW_13_1_X_2023-02-14-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40771/30636/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3556272
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3556247
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19862
  • DQMHistoTests: Total failures: 282
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19580
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 1 / 3 workflows

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 15, 2023

+heterogeneous

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants