Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpaka-related updates [13.0.x] #40772

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 15, 2023

PR description:

Various Alpaka-related updates:

  • move HeterogeneousCore/AlpakaCore/interface/MakerMacros.h under alpaka/
  • rename alpaka_hip_async to alpaka_rocm_async
  • adopt the "alternative module loading" approach in the Alpaka test

PR validation:

All unit tests should pass.

PR backport:

Backport of #40771 to CMSSW_13_0_X for 2023 data taking.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 15, 2023

backport #40771

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_0_X.

It involves the following packages:

  • FWCore/ParameterSet (core)
  • HeterogeneousCore/AlpakaCore (heterogeneous)
  • HeterogeneousCore/AlpakaInterface (heterogeneous)
  • HeterogeneousCore/AlpakaTest (heterogeneous)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard fwyzard force-pushed the Alpaka_updates_13.0.x branch from 6dcca0a to 3cd90b2 Compare February 15, 2023 00:15
@cmsbuild
Copy link
Contributor

Pull request #40772 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel, @fwyzard can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 15, 2023

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 15, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76a5a7/30637/summary.html
COMMIT: 3cd90b2
CMSSW: CMSSW_13_0_X_2023-02-14-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40772/30637/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555972
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555947
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19862
  • DQMHistoTests: Total failures: 42
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19820
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 15, 2023

+heterogeneous

@makortel
Copy link
Contributor

+core

Exactly the same commits as in #40771

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8fd84e2 into cms-sw:CMSSW_13_0_X Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants