Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4.20 release planning #674

Closed
hoodmane opened this issue Apr 9, 2022 · 13 comments
Closed

0.4.20 release planning #674

hoodmane opened this issue Apr 9, 2022 · 13 comments

Comments

@hoodmane
Copy link

hoodmane commented Apr 9, 2022

Currently to build downstream packages for targets emscripten, I clone a fork of chrono with #593 backported onto v0.4.19 and patch the downstream package's Cargo.toml by adding

+[patch.crates-io]
+chrono = { path =  "path/to/forked/chrono" }

I am looking forward to not having to do this.

@djc djc changed the title Release with fix for emscripten target Next release planning Apr 11, 2022
@djc
Copy link
Member

djc commented Apr 12, 2022

We can do a beta release for now, see #676. In order to get to a 0.4.20 final release I want to merge #677 (or some other solution for #499) and ideally we'll then do some release candidate testing.

autarch added a commit to autarch/octocrab that referenced this issue Apr 23, 2022
This doesn't fix all the issues, because this crate still depends on chrono
0.4.19, which as a potential segfault. But there's no newer version of chrono
yet. See chronotope/chrono#674 for discussion of the
0.4.20 release.
autarch added a commit to autarch/octocrab that referenced this issue Apr 23, 2022
This doesn't fix all the issues, because this crate still depends on chrono
0.4.19, which as a potential segfault. But there's no newer version of chrono
yet. See chronotope/chrono#674 for discussion of the
0.4.20 release.
@cramhead
Copy link

cramhead commented Jun 2, 2022

I notice that version 0.4.19 is using version 0.1.43 of the time crate. I noticed https://rustsec.org/advisories/RUSTSEC-2020-0071 today via cargo audit. After looking into time a little I see that time is now on version 0.3.9, https://github.com/time-rs/time/blob/main/Cargo.toml.
Could we add an upgrade to time to the next release?
I'd be happy to contribute, but I'm pretty new to rust.

@Stargateur
Copy link

Stargateur commented Jun 2, 2022

@cramhead this CVE doesn't affect chrono see #602

@krojew
Copy link

krojew commented Jun 22, 2022

Any info when the new version will be released?

@djc
Copy link
Member

djc commented Jun 23, 2022

I guess we can release it at any time and make further compatible changes later. Let's get a beta or rc out first (see #676) so we can get some more testing before we push this out to the rest of the world.

@cgorski-airtime
Copy link

Is there a preferred way to track and provide feedback for the beta release? I am interested in helping to get the beta into an official release.

@djc
Copy link
Member

djc commented Jul 25, 2022

I've published 0.4.20-beta.1 to crates.io, would be happy to get everyone to test it!

@hoodmane
Copy link
Author

Thanks @djc and chrono maintainers!

@djc djc pinned this issue Jul 25, 2022
@djc
Copy link
Member

djc commented Jul 26, 2022

I've published an rc.1 and written up some release notes for it: https://github.com/chronotope/chrono/releases/tag/v0.4.20-rc.1. Please let me know if anything is missing/unclear (@esheppa would especially value your feedback on the release notes).

@djc djc changed the title Next release planning 0.4.20 release planning Jul 26, 2022
@esheppa
Copy link
Collaborator

esheppa commented Jul 27, 2022

@djc - the release notes look great! (However they made me realize that I probably need to document the behavior of the caching of the tzfile data)

Potentially we could add the following:

@djc
Copy link
Member

djc commented Jul 27, 2022

rkyv support was already there, near the top of the additions. I missed #522 on my previous run, and also added #572, #588 and #609.

@djc
Copy link
Member

djc commented Aug 4, 2022

0.4.20 has been released!

@djc djc closed this as completed Aug 4, 2022
@Xuanwo
Copy link

Xuanwo commented Aug 5, 2022

databend has switched it's chrono's stream back to chronotope/chrono in databendlabs/databend#6928.

No build failure, no tests broken, no performance regression.

I believe this version is good for everyone to upgrade.

Nice work @djc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants