Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DateTime::from_local() #572

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Add DateTime::from_local() #572

merged 4 commits into from
Oct 26, 2021

Conversation

retrhelo
Copy link

@retrhelo retrhelo commented Jul 1, 2021

Add a new method from_local() to DateTime, opposite to from_utc(), so user can construct DateTime from a NaiveDateTime instance in non-UTC time zone.

Milo123459
Milo123459 reviewed Oct 25, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Milo123459
Copy link
Member

Please run cargo fmt

@retrhelo
Copy link
Author

retrhelo commented Oct 26, 2021 •
edited
Loading

I made some modify to the comments in Datetime::from_local() and pass cargo fmt on my local environment now. Please let me know if there's any work I should do. Modification is committed, and ready for review.

@Milo123459 Milo123459 merged commit 1e49400 into chronotope:main Oct 26, 2021
@retrhelo retrhelo deleted the localdate branch October 26, 2021 09:43
@djc djc mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milo123459 Milo123459 Milo123459 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@retrhelo @Milo123459