Implement std::iter::Sum for Duration #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is giving me this clippy error that seems unrelated to my code: https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains - any idea why? |
|
I have opened #525 to allow the lint. |
|
@jakevossen5 sorry about the delay, I've merged @robyoung 's PR (thanks!), if you rebase on main then the clippy lint should not bother you. |
|
Should be good for review now! |
|
Any update on this? |
Milo123459
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
LGTM. Just going to wait for @quodlibetor to give me the go-ahead before merging.
|
Any update on this? Thanks! |
|
Thanks for working on this! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to chrono!
about adding the PR number)
we can't reintroduce it?
Closes #520