add optional rkyv support #644
Conversation
|
This seems to have a lot of unrelated of changes. I'm afraid the changes in #661 have caused quite a few conflicts, but if you would rebase this on current main and make only the minimal changes necessary to support rkyv I'd be happy to review this. |
|
@djc Done. |
src/date.rs
Outdated
| @@ -18,7 +18,8 @@ use crate::naive::{self, IsoWeek, NaiveDate, NaiveTime}; | |||
| use crate::offset::{TimeZone, Utc}; | |||
| use crate::DateTime; | |||
| use crate::{Datelike, Weekday}; | |||
|
|
|||
| #[cfg(feature = "rkyv")] | |||
| use rkyv::{Archive, Deserialize, Serialize}; | |||
There was a problem hiding this comment.
Please put this in a separate block of imports, between the std/core block and the crate-internal imports. (Same for all the other imports.)
There was a problem hiding this comment.
do you want me to fix existing incorrect import orders as well? Some files are already not obeying this, e.g. src/naive/date.rs
There was a problem hiding this comment.
It's not necessary for me to merge this PR, but if you don't mind doing the work that would be great! Please do it as a separate commit.
Thanks for contributing to chrono!
about adding the PR number)
we can't reintroduce it?
Fixes #583