Remove deprecations

[sequencer]

Depends on freechipsproject/chisel-testers#309

Contributor Checklist

• Did you add Scaladoc to every public function/method?
• Did you add at least one test demonstrating the PR?
• Did you delete any extraneous printlns/debugging code?
• Did you specify the type of improvement?
• Did you add appropriate documentation in docs/src?
• Did you state the API impact?
• Did you specify the code generation impact?
• Did you request a desired merge strategy?
• Did you add text to be included in the Release Notes for this change?

Type of Improvement

• code cleanup

API Impact

Remove all deprecated API in before and include 3.2

Desired Merge Strategy

• Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Remove deprecations since and include 3.2

Reviewer Checklist (only modified by reviewer)

• Did you add the appropriate labels?
• Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
• Did you review?
• Did you check whether all relevant Contributor checkboxes have been checked?
• Did you mark as Please Merge?

[sequencer]

Although it's deprecated in 3.3, I removed this since it's a internal API and no other place use it.
And it claims to be removed in in 3.4. ;p

[jackkoenig]

I like the idea here, but we unfortunately can't remove everything that's deprecated. The chisel-iotesters only use chisel3.Driver and ExecutionOptionsManager so until either they stop or we stop supporting chisel-iotesters, we're kind of stuck with those. @chick @seldridge is there anything else we're stuck with at the moment?

If you could put remove 2.11 in a different PR I'd love to fast track that one 🚀

[jackkoenig]

I think we've discussed pulling ExecutionOptionsManager out of chisel3 and firrtl and into chisel-iotesters, if someone wants to tackle that that would vastly clean up the code here.

[sequencer]

If you could put remove 2.11 in a different PR I'd love to fast track that one rocket

This PR is rebase onto #1732 now ;)

The chisel-iotesters only use chisel3.Driver and ExecutionOptionsManager so until either they stop or we stop supporting chisel-iotesters, we're kind of stuck with those.

I will take a look today.

[sequencer]

The chisel-iotesters only use chisel3.Driver and ExecutionOptionsManager so until either they stop or we stop supporting chisel-iotesters, we're kind of stuck with those. @chick @seldridge is there anything else we're stuck with at the moment?

Just take another hour on freechipsproject/chisel-testers#309, it should not be a blocker now:

[info] ScalaTest
[info] Run completed in 3 minutes, 43 seconds.
[info] Total number of tests run: 109
[info] Suites: completed 49, aborted 0
[info] Tests: succeeded 109, failed 0, canceled 2, ignored 1, pending 0
[info] All tests passed.
[info] Passed: Total 109, Failed 0, Errors 0, Passed 109, Ignored 1, Canceled 2
[success] Total time: 258 s (04:18), completed Jan 15, 2021, 5:56:20 PM

[chick]

@sequencer

repo	branch	hash
firrtl	master	aec9e9e
firrtl-interpeter	master	937c44d7ca19c3daca8eea9c52cbaff5476c311b
treadle	master	0ec32a5112a2cf0b9741790cf8c8ebb4b8794ddf
chisel3	remove_deprecations	8391247

chisel3 built and passed tests.

[jackkoenig]

@chick did you check upstream repos? chisel-iotesters (with the related PR), chisel-test, and dsp-tools?

[chick]

I started testing but got stuck at iotesters. I talked to @sequencer and he said he would fix.

[sequencer]

I tested this, those was introduced by remove io. I’ll fix that today.

[jackkoenig]