Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for latest chisel, remove toBool and chisel3.core. #126

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

sequencer
Copy link
Contributor

No description provided.

@colinschmidt
Copy link
Contributor

We will need to test this with chipyard before merging.

@sequencer
Copy link
Contributor Author

Thanks! This PR is subsequent to chipsalliance/chisel#1730.

@sequencer
Copy link
Contributor Author

any update on this PR?

@sequencer
Copy link
Contributor Author

I think it's safe to merge:
related to chipsalliance/chisel#1730 :

diff --git a/core/src/main/scala/chisel3/Bits.scala b/core/src/main/scala/chisel3/Bits.scala
index c86e92085..17829143b 100644
--- a/core/src/main/scala/chisel3/Bits.scala
+++ b/core/src/main/scala/chisel3/Bits.scala
@@ -29,15 +29,6 @@ private[chisel3] sealed trait ToBoolable extends Element {
 
   /** @group SourceInfoTransformMacro */
   def do_asBool(implicit sourceInfo: SourceInfo, compileOptions: CompileOptions): Bool
-
-  /** Casts this $coll to a [[Bool]]
-    *
-    * @note The width must be known and equal to 1
-    */
-  final def toBool(): Bool = macro SourceInfoWhiteboxTransform.noArg
-
-  /** @group SourceInfoTransformMacro */
-  def do_toBool(implicit sourceInfo: SourceInfo, compileOptions: CompileOptions): Bool
 }
 
 /** A data type for values represented by a single bitvector. This provides basic bitwise operations.
@@ -315,11 +306,6 @@ sealed abstract class Bits(private[chisel3] val width: Width) extends Element wi
   /** Returns the contents of this wire as a [[scala.collection.Seq]] of [[Bool]]. */
   final def toBools(): Seq[Bool] = macro SourceInfoTransform.noArg
 
-  /** @group SourceInfoTransformMacro */
-  @chiselRuntimeDeprecated
-  @deprecated("Use asBools instead", "3.2")
-  def do_toBools(implicit sourceInfo: SourceInfo, compileOptions: CompileOptions): Seq[Bool] = do_asBools
-
   /** Returns the contents of this wire as a [[scala.collection.Seq]] of [[Bool]]. */
   final def asBools(): Seq[Bool] = macro SourceInfoTransform.noArg
 
@@ -369,10 +355,6 @@ sealed abstract class Bits(private[chisel3] val width: Width) extends Element wi
     }
   }
 
-  @chiselRuntimeDeprecated
-  @deprecated("Use asBool instead", "3.2")
-  final def do_toBool(implicit sourceInfo: SourceInfo, compileOptions: CompileOptions): Bool = do_asBool
-

@colinschmidt
Copy link
Contributor

@alonamid Is going to make the chipyard PR that incorporates this and the other deprecation fixes you've made recently.

@sequencer
Copy link
Contributor Author

Hi @colinschmidt, can we get this in now? :)

@sequencer
Copy link
Contributor Author

ping

@jerryz123
Copy link
Contributor

@sequencer Were you going to open a Chipyard PR aggregating all your bumps?

@sequencer
Copy link
Contributor Author

sequencer commented May 17, 2021

Sure :)

@davidbiancolin
Copy link
Contributor

These are not RTL changing, the same changes have been made in multiple submodules, so i'm going to green light this as it helps with my chisel bump.

I will be making the aggregating bump in CY.

@davidbiancolin davidbiancolin merged commit 380583a into ucb-bar:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants