Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoder Tracking PR #1728

Closed
wants to merge 26 commits into from
Closed

Decoder Tracking PR #1728

wants to merge 26 commits into from

Conversation

sequencer
Copy link
Member

@sequencer sequencer commented Jan 14, 2021

This PR is a merge commit to track #1914 #1913 #1911
Review should happen there, after all those PR get approved, we can directly merge this PR.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

  • Add Decoder API with two backends: QMC and espresso

Backend Code Generation Impact

None

Desired Merge Strategy

  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

  • Add Decoder API with two backends: QMC and espresso

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@sequencer sequencer requested a review from aswaterman January 14, 2021 06:20
@sequencer sequencer mentioned this pull request Jan 15, 2021
14 tasks
@sequencer sequencer force-pushed the decoder branch 2 times, most recently from 6ab0262 to b76dff8 Compare January 21, 2021 01:08
@sequencer sequencer force-pushed the decoder branch 2 times, most recently from 7f1df36 to 94d7096 Compare January 25, 2021 07:16
@sequencer sequencer force-pushed the decoder branch 2 times, most recently from de7a507 to 1404909 Compare February 5, 2021 02:11
@sequencer sequencer force-pushed the decoder branch 2 times, most recently from 3ebe832 to cec872e Compare May 5, 2021 07:16
@sequencer sequencer force-pushed the decoder branch 2 times, most recently from b23972e to 0bf35a1 Compare May 16, 2021 05:12
@sequencer sequencer changed the title First step on decode API Decoder API May 17, 2021
@sequencer sequencer force-pushed the decoder branch 10 times, most recently from 0a333a2 to 1931f77 Compare May 20, 2021 06:36
@sequencer sequencer changed the title Decoder API Decoder Tracking API May 20, 2021
@sequencer sequencer force-pushed the decoder branch 2 times, most recently from 1f4f2f7 to b5bac77 Compare June 15, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants