Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Decoder API and Tests #1913

Closed
wants to merge 15 commits into from
Closed

Basic Decoder API and Tests #1913

wants to merge 15 commits into from

Conversation

sequencer
Copy link
Member

This PR depends on #1912
This PR implements Decoder API and its tests.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.x, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@sequencer sequencer mentioned this pull request May 12, 2021
Closed
14 tasks
@sequencer sequencer force-pushed the decoder_api branch 4 times, most recently from 041afb5 to c5bc30e Compare May 16, 2021 05:14
@sequencer sequencer mentioned this pull request May 17, 2021
Closed
14 tasks
@sequencer sequencer force-pushed the decoder_api branch 6 times, most recently from 9c6062b to 27e347c Compare May 25, 2021 05:42
@sequencer sequencer force-pushed the decoder_api branch 4 times, most recently from d040c84 to d75c518 Compare June 15, 2021 16:29
@sequencer @jackkoenig
Apply Jack's Review
f19db47 
1. `TruthTable` is final now.
2. add return type for `TruthTable`

Co-authored-by: Jack Koenig <[email protected]>
@sequencer sequencer closed this Jun 16, 2021
@sequencer sequencer deleted the decoder_api branch July 15, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sequencer @yqszxx