Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Decoder result #1733

Closed
wants to merge 6 commits into from
Closed

Cache Decoder result #1733

wants to merge 6 commits into from

Conversation

sequencer
Copy link
Member

This is the example to cache decoder in different elaborations.
decoder serialization and deserialization is under WIP.
depend on PR #1731 and #1728
This solved the performance issue @aswaterman mentioned in #1187

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • performance improvement

API Impact

Add Annotation to store QMC decode table.

Backend Code Generation Impact

None

Desired Merge Strategy

  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Cache decode result.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@sequencer sequencer force-pushed the decoder_annotation branch 3 times, most recently from b464be6 to 8ab6fab Compare January 16, 2021 06:40
@sequencer
Copy link
Member Author

Close since it's my misunderstanding to original QMC cache system.

@sequencer sequencer closed this Feb 26, 2021
@sequencer sequencer deleted the decoder_annotation branch July 15, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant