Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement QMC decoder #1911

Merged
merged 21 commits into from
Jun 16, 2021
Merged

Implement QMC decoder #1911

merged 21 commits into from
Jun 16, 2021

Conversation

sequencer
Copy link
Member

This PR depends on #1904

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.x, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@sequencer sequencer force-pushed the qmc branch 4 times, most recently from 793bf55 to 0e5537e Compare May 16, 2021 05:13
@sequencer sequencer mentioned this pull request May 17, 2021
Closed
14 tasks
yqszxx
yqszxx suggested changes May 23, 2021
View reviewed changes
Copy link
Contributor

@yqszxx yqszxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix returned truth table map first

src/main/scala/chisel3/util/experimental/decode/QMCMinimizer.scala Outdated Show resolved Hide resolved
@sequencer sequencer force-pushed the qmc branch 2 times, most recently from 28b8f1e to 084c266 Compare May 23, 2021 11:37
@sequencer sequencer requested a review from aswaterman May 23, 2021 11:46
@aswaterman
Copy link
Member

I'm essentially OK with this on technical grounds, provided we still agree we are going to replace it with invocation of Espresso. I'd like @jackkoenig to perform the actual detailed code review, though.

@sequencer sequencer requested a review from jackkoenig May 25, 2021 01:24
@sequencer sequencer force-pushed the qmc branch 3 times, most recently from c27d4c1 to d2136e1 Compare May 25, 2021 05:44
jackkoenig
jackkoenig reviewed Jun 12, 2021
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks pretty good (although I didn't review the QMC implementation in detail, I'll have to trust that it's tested well, maybe a few more tests would be helpful).

Just a few comments/questions.

src/main/scala/chisel3/util/experimental/decode/TruthTable.scala Outdated Show resolved Hide resolved
src/main/scala/chisel3/util/experimental/decode/TruthTable.scala Show resolved Hide resolved
src/main/scala/chisel3/util/experimental/decode/TruthTable.scala Outdated Show resolved Hide resolved
src/main/scala/chisel3/util/experimental/decode/DecodeTableAnnotation.scala Show resolved Hide resolved
@sequencer
Copy link
Member Author

sequencer commented Jun 12, 2021 •
edited
Loading

Really appreciate Jack’s review! Thanks for your time!

although I didn't review the QMC implementation in detail, I'll have to trust that it's tested well, maybe a few more tests would be helpful

We(PLCT) did a long review to rocket QMC, I think I and @yqszxx have fully Understood the internal of those codes, so even there exist some bugs, we are able to fix them.

As for the test, I think we can steal some test cases from espresso, however this may increase our test yield time to test some bigger cases. Is this necessary?

I’m in Beijing these days, so I might now be able to fix those requested changes now, I’ll work on this after backing to Shanghai. Sorry for that.

@sequencer sequencer force-pushed the qmc branch 9 times, most recently from 717bdfa to b86fae6 Compare June 14, 2021 17:46
@jackkoenig jackkoenig added this to the 3.5.0 milestone Jun 15, 2021
sequencer and others added 21 commits June 16, 2021 02:07
@sequencer
implement TruthTable to represent a decode table.
3c3b785
@sequencer
implement DecodeTableAnnotation for decode table caching.
eac62df
@sequencer
TruthTable can merge same inputs now.
304c8d7
@sequencer
fix for 2.13
c51716c
@sequencer
implement abstract Minimizer as a general API.
c449b91
@sequencer
add a simple decoder API.
f856345
@sequencer
async decoder with 5 seconds timeout.
940551b
@sequencer
remove all timeouts by review.
a0832ed
@sequencer
test decode cache.
1bc370d
@sequencer
use z3 formal check minimized circuit and reference model.
065f1fc
@yqszxx @sequencer
Add minimized form of test cases
5ec9f4a
@sequencer
switch to EndToEndSMTBaseSpec
df1e21c
@sequencer
Add test cases.
beb1118
@sequencer
add documentation for DecodeTableAnnotation.
3732175
@sequencer @jackkoenig
Apply Jack's Review
f19db47 
1. `TruthTable` is final now.
2. add return type for `TruthTable`

Co-authored-by: Jack Koenig <[email protected]>
@sequencer
Merge branch 'decoder_api'
9aa5ec9
@yqszxx @sequencer
implement QMC.
0f3c33e
@yqszxx @sequencer
Merge minimized table before return as a TruthTable
92bd2c1
@yqszxx @sequencer
Refactor to a more scala form
b9157b3
@yqszxx @sequencer
Add computational complexity analysis
19dc01e
@sequencer
implement test for qmc
794d6b8
@sequencer sequencer merged commit b860a81 into master Jun 16, 2021
@sequencer
Copy link
Member Author

Thanks @jackkoenig ! Decoder finally landed!

@yqszxx
Copy link
Contributor

yqszxx commented Jun 17, 2021

🎉Hooray~

@jackkoenig jackkoenig deleted the qmc branch July 7, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswaterman aswaterman aswaterman left review comments

@yqszxx yqszxx yqszxx requested changes

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sequencer @aswaterman @yqszxx @jackkoenig