Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsed to copy number should accept request body rather than query params #458

Closed
korikuzma opened this issue Jul 3, 2023 · 2 comments
Closed

parsed to copy number should accept request body rather than query params #458

korikuzma opened this issue Jul 3, 2023 · 2 comments
Assignees
@korikuzma
Labels
priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"

Comments

@korikuzma
Copy link
Member

There are a ton of query string parameters. We should switch to using request body instead
@korikuzma korikuzma added priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Jul 3, 2023
@korikuzma korikuzma self-assigned this Jul 3, 2023
@korikuzma
Copy link
Member Author

This was done for metaschema in #460

@korikuzma korikuzma mentioned this issue Sep 7, 2023
Merged
korikuzma added a commit that referenced this issue Sep 7, 2023
@korikuzma
feat!: add / update to copy number methods from metaschema branch (#508)
8b2e582 
Close #450 , #458 , #465 , #444

Notes:
- feat: add parsed to copy number change endpoint (#453)
- fix!: /parsed_to_cn_var should accept number, definite range, and indefinite range (#455)
- feat: add do_liftover param in parsed to copy number endpoints (#459)
- refactor!: parsed to copy number should accept request body (#460)
- fix: Copy Number Count copies should be Number or Indef/Def Range (#468)
- fix: allow comparator to be set in start/end values (#469)
korikuzma added a commit that referenced this issue Sep 22, 2023
@korikuzma
feat!: add / update to copy number methods from metaschema branch (#508)
9b1c3ee 
Close #450 , #458 , #465 , #444

Notes:
- feat: add parsed to copy number change endpoint (#453)
- fix!: /parsed_to_cn_var should accept number, definite range, and indefinite range (#455)
- feat: add do_liftover param in parsed to copy number endpoints (#459)
- refactor!: parsed to copy number should accept request body (#460)
- fix: Copy Number Count copies should be Number or Indef/Def Range (#468)
- fix: allow comparator to be set in start/end values (#469)
@korikuzma
Copy link
Member Author

This was done for main in #508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@korikuzma