Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: /parsed_to_cn_var should accept number, definite range, and indefinite range #455

Merged
merged 12 commits into from
Jun 26, 2023

Conversation

korikuzma
Copy link
Member

addresses #443 for metaschema . This work is needed for the manuscript analysis

  • Merges parsed_to_cn_var and parsed_to_cx_var work into parsed_to_copy_number
  • ac/chr/assembly check is now done in the Pydantic model

@korikuzma korikuzma added bug Something isn't working priority:high High priority labels Jun 22, 2023
@korikuzma korikuzma requested a review from jsstevenson June 22, 2023 13:08
@korikuzma korikuzma self-assigned this Jun 22, 2023
variation/main.py Outdated Show resolved Hide resolved
@korikuzma korikuzma requested a review from jsstevenson June 22, 2023 17:35
jsstevenson
jsstevenson previously approved these changes Jun 22, 2023
Base automatically changed from issue-444-metaschema to staging June 22, 2023 19:53
@korikuzma korikuzma dismissed jsstevenson’s stale review June 22, 2023 19:53

The base branch was changed.

@korikuzma korikuzma requested a review from jsstevenson June 22, 2023 20:40
@korikuzma korikuzma merged commit 0b299fe into staging Jun 26, 2023
@korikuzma korikuzma deleted the issue-443-metaschema branch June 26, 2023 11:19
@korikuzma korikuzma added priority:low Low priority and removed priority:high High priority labels Jul 3, 2023
korikuzma added a commit that referenced this pull request Sep 7, 2023
Close #450 , #458 , #465 , #444

Notes:
- feat: add parsed to copy number change endpoint (#453)
- fix!: /parsed_to_cn_var should accept number, definite range, and indefinite range (#455)
- feat: add do_liftover param in parsed to copy number endpoints (#459)
- refactor!: parsed to copy number should accept request body (#460)
- fix: Copy Number Count copies should be Number or Indef/Def Range (#468)
- fix: allow comparator to be set in start/end values (#469)
korikuzma added a commit that referenced this pull request Sep 22, 2023
Close #450 , #458 , #465 , #444

Notes:
- feat: add parsed to copy number change endpoint (#453)
- fix!: /parsed_to_cn_var should accept number, definite range, and indefinite range (#455)
- feat: add do_liftover param in parsed to copy number endpoints (#459)
- refactor!: parsed to copy number should accept request body (#460)
- fix: Copy Number Count copies should be Number or Indef/Def Range (#468)
- fix: allow comparator to be set in start/end values (#469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:low Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants