Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copy Number Count copies should be Number or Indef/Def Range #468

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

korikuzma
Copy link
Member

Addresses #443 for metaschema branch. Needed for manuscript analysis

  • Provides descriptions for Parsed to CN query classes
  • total_copies renamed to copies0

@korikuzma korikuzma added bug Something isn't working priority:high High priority labels Jul 18, 2023
@korikuzma korikuzma requested a review from jsstevenson July 18, 2023 16:58
@korikuzma korikuzma self-assigned this Jul 18, 2023
Copy link
Member

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

variation/schemas/copy_number_schema.py Outdated Show resolved Hide resolved
@korikuzma korikuzma requested a review from jsstevenson July 18, 2023 18:51
@korikuzma korikuzma merged commit 5c91c55 into staging Jul 18, 2023
@korikuzma korikuzma deleted the issue-443-metaschema branch July 18, 2023 18:56
korikuzma added a commit that referenced this pull request Sep 7, 2023
Close #450 , #458 , #465 , #444

Notes:
- feat: add parsed to copy number change endpoint (#453)
- fix!: /parsed_to_cn_var should accept number, definite range, and indefinite range (#455)
- feat: add do_liftover param in parsed to copy number endpoints (#459)
- refactor!: parsed to copy number should accept request body (#460)
- fix: Copy Number Count copies should be Number or Indef/Def Range (#468)
- fix: allow comparator to be set in start/end values (#469)
korikuzma added a commit that referenced this pull request Sep 22, 2023
Close #450 , #458 , #465 , #444

Notes:
- feat: add parsed to copy number change endpoint (#453)
- fix!: /parsed_to_cn_var should accept number, definite range, and indefinite range (#455)
- feat: add do_liftover param in parsed to copy number endpoints (#459)
- refactor!: parsed to copy number should accept request body (#460)
- fix: Copy Number Count copies should be Number or Indef/Def Range (#468)
- fix: allow comparator to be set in start/end values (#469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants