Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: parsed to copy number should accept request body (metaschema) #460

Merged
merged 18 commits into from
Jul 6, 2023

Conversation

korikuzma
Copy link
Member

Addresses #450 for metaschema . Needed for variation manuscript analysis work

Notes:

  • Parsed to copy number accepts request body (ParsedToCxVarQuery or ParsedToCnVarQuery) rather than query string parameters
  • Parsed to copy number are now POST methods
  • Removes query from ParsedToCxVarService and ParsedToCnVarService model

@korikuzma korikuzma added priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Jul 3, 2023
@korikuzma korikuzma requested a review from jsstevenson July 3, 2023 19:51
@korikuzma korikuzma self-assigned this Jul 3, 2023
jsstevenson
jsstevenson previously approved these changes Jul 5, 2023
Copy link
Member

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from issue-450 to staging July 6, 2023 12:43
@korikuzma korikuzma dismissed jsstevenson’s stale review July 6, 2023 12:43

The base branch was changed.

@korikuzma korikuzma requested a review from jsstevenson July 6, 2023 13:12
korikuzma added a commit that referenced this pull request Sep 7, 2023
Close #450 , #458 , #465 , #444

Notes:
- feat: add parsed to copy number change endpoint (#453)
- fix!: /parsed_to_cn_var should accept number, definite range, and indefinite range (#455)
- feat: add do_liftover param in parsed to copy number endpoints (#459)
- refactor!: parsed to copy number should accept request body (#460)
- fix: Copy Number Count copies should be Number or Indef/Def Range (#468)
- fix: allow comparator to be set in start/end values (#469)
korikuzma added a commit that referenced this pull request Sep 22, 2023
Close #450 , #458 , #465 , #444

Notes:
- feat: add parsed to copy number change endpoint (#453)
- fix!: /parsed_to_cn_var should accept number, definite range, and indefinite range (#455)
- feat: add do_liftover param in parsed to copy number endpoints (#459)
- refactor!: parsed to copy number should accept request body (#460)
- fix: Copy Number Count copies should be Number or Indef/Def Range (#468)
- fix: allow comparator to be set in start/end values (#469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants