-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: parsed to copy number should accept request body (metaschema) #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
added
priority:high
High priority
technical debt
A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
labels
Jul 3, 2023
jsstevenson
previously approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
jsstevenson
approved these changes
Jul 6, 2023
korikuzma
added a commit
that referenced
this pull request
Sep 7, 2023
Close #450 , #458 , #465 , #444 Notes: - feat: add parsed to copy number change endpoint (#453) - fix!: /parsed_to_cn_var should accept number, definite range, and indefinite range (#455) - feat: add do_liftover param in parsed to copy number endpoints (#459) - refactor!: parsed to copy number should accept request body (#460) - fix: Copy Number Count copies should be Number or Indef/Def Range (#468) - fix: allow comparator to be set in start/end values (#469)
korikuzma
added a commit
that referenced
this pull request
Sep 22, 2023
Close #450 , #458 , #465 , #444 Notes: - feat: add parsed to copy number change endpoint (#453) - fix!: /parsed_to_cn_var should accept number, definite range, and indefinite range (#455) - feat: add do_liftover param in parsed to copy number endpoints (#459) - refactor!: parsed to copy number should accept request body (#460) - fix: Copy Number Count copies should be Number or Indef/Def Range (#468) - fix: allow comparator to be set in start/end values (#469)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority:high
High priority
technical debt
A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #450 for metaschema . Needed for variation manuscript analysis work
Notes:
ParsedToCxVarQuery
orParsedToCnVarQuery
) rather than query string parametersquery
fromParsedToCxVarService
andParsedToCnVarService
model