-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
newstudy/mixed_nfosi_2022 #1736
Conversation
@rmadupuri and @anngvu During additional testing of the variant calls it has come to our notice that the variants included in this PR may not have been filtered completely to remove all germline variants and false positives. We are currently generating a new merged MAF file to accompany this PR with filtered variants to exclude any false positives or germline variants. Our goal is to replace the merged MAF file by the end of this week. @rmadupuri would you be okay to hold reviewing this PR until next week? |
@jaybee84 of course! Let us know when the data is fixed and ready for review. |
@rmadupuri @jaybee84 Replaced with updated mutations data file. I took a look at https://output.circle-artifacts.com/output/job/9a956c59-873e-49d1-9943-acd33ac8d41a/artifacts/0/~/test-reports/ERRORS/mixed_nfosi_2022-validation.html and it's still just the genome reference check. |
@rmadupuri You do a squash merge, right? |
@anngvu thanks for the fixes. Yes we do a squash merge. |
@rmadupuri Thanks for the questions:
In the scope of this paper, only 18 patients had matched tumor-normal samples for somatic variant calling so we could only submit samples from 18 patients. We are only submitting somatic calls according to GATK best practices. While it is not in the scope of the attached publication, but these samples are from a Biobank. We are currently preparing to release another batch of samples and data, that we would like to add to cBioPortal. This submission is a pilot batch to test and finalize our internal processes for later submissions.
We have RNAseq data from these patients and are hoping to submit them in this year. |
Got it. Thanks @jaybee84! Here are a few meta data corrections needed. Can we update the study identifier to meta_study.txt:
mutations data:
case lists:
Thanks! |
tagging @anngvu for the suggested updates to the PR. Thanks for the review @rmadupuri ! |
@rmadupuri Also thanks for the review! 🙏 I applied suggested changes. |
Thanks for the fixes @anngvu! We have added a few edits and standardized the files to cBioPortal formats in #1760 (I was not able to push my commits to your branch cause of access issues). Closing this PR here and we will merge the data along with your commits in PR 1760. Thanks so much again for all the work. We will update you once the data is released to public portal. |
Cancer studies updated in this pull request:
Submitting new public study on behalf of NF-OSI as described here: #1734
For issues with the submission, please comment on nf-osi#1 and we'll try to resolve (e.g. if you'd like to remove the HTML validation report). This might fail the genome reference check, but we were told by @ritikakundra and Thomas Yu that this should be OK?
checks
For all pull requests:
For a new study (in addition to above):