Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A clinically and genomically annotated nerve sheath tumor biospecimen repository. Pollard et al. Sci Data 2020 #1734

Closed
9 tasks done
anngvu opened this issue Nov 16, 2022 · 11 comments

Comments

@anngvu
Copy link
Contributor

anngvu commented Nov 16, 2022

This is a proposed new public study. Raw genomics data was generated for this study in 2020 and is stored on Synapse: JHU Biobank project. In 2022, the lab had contract support for NF-OSI team at Sage to process the data and submit a very small subset to the public cBioPortal (because we're excluding a lot of germline data). Processing pipelines are described here: NPD-Nextflow Data Processing & Configuration-161122-155435.pdf.

@anngvu anngvu changed the title A clinically and genomically annotated nerve sheath tumor biospecimen repository. Pollard et al. 2020 A clinically and genomically annotated nerve sheath tumor biospecimen repository. Pollard et al. Sci Data 2020 Nov 16, 2022
@anngvu
Copy link
Contributor Author

anngvu commented Nov 16, 2022

@inodb @ritikakundra Question about the public cBioPortal requring GRCh37 -- I was told Thomas Yu had a meeting (with Ino, I think) and said the public portal will be moving to/accepting GRCh38 soon? Currently the checklist and validation still requires GRCh37.

@anngvu anngvu mentioned this issue Nov 22, 2022
14 tasks
@allaway
Copy link
Contributor

allaway commented Jan 10, 2023

Hello all, I was wondering if there was any update on this data deposit? Thanks!

@rmadupuri
Copy link
Collaborator

Hi @allaway @anngvu @jaybee84! The study is now released to the public cBioPortal at https://www.cbioportal.org/study/summary?id=nst_nfosi_ntap. Could you review the data to make sure everything looks right?

Thanks so much!

@allaway allaway mentioned this issue Feb 3, 2023
14 tasks
@allaway
Copy link
Contributor

allaway commented Feb 3, 2023

Hi @rmadupuri, thanks so much for this! I have opened a PR to make some minor wording changes in the description. I'll leave the review of the actual data to @jaybee84 as she is much more familiar with it than I.

@jaybee84 jaybee84 mentioned this issue Feb 3, 2023
14 tasks
@jaybee84
Copy link
Contributor

jaybee84 commented Feb 3, 2023

The initial spot checks with the data looks good. There are some differences in the variants identified in this submission compared to the original publication. Most likely the difference has arisen due to differences in reprocessing parameters as well as the reference genome build. I added a sentence in the study description to make that explicit.

@jaybee84
Copy link
Contributor

jaybee84 commented Feb 3, 2023

@rmadupuri just wanted to attract your attention to a more recent PR that helps avoid code jargon in the description (that I had added earlier). Thanks again for the review and addition.

@jaybee84
Copy link
Contributor

jaybee84 commented Feb 4, 2023

@rmadupuri I was looking through the genes reported as having variants in these samples on cbioportal and found a gene called FOCAD with variant in one sample. But I could not find this gene in the original mutation MAF file on my end. Do you have a guess what may be happening here?

@rmadupuri
Copy link
Collaborator

@jaybee84 thanks for the corrections. The changes are now public.

I do see one FOCAD Splice variant in the original submission here https://github.com/nf-osi/datahub/blob/d929f69a212861b4cb14ef97240d0e9e06ca0122/public/mixed_nfosi_2022/data_mutations.txt from PR #1736. Let us know if there's any issues.

@jaybee84
Copy link
Contributor

@rmadupuri Sorry for my delayed response, I was out of office. I am following up on the noted difference and will report back soon.

@jaybee84
Copy link
Contributor

jaybee84 commented Feb 10, 2023

It looks like I was missing the above mentioned variant because I was seeing only a subset of the variants on my end. This was because I was using an analytical package function to read the original MAF file that filters out the silent variants. So this variant was being filtered out.

This issue is resolved from my end. The updated mutations.txt file and the original maf file are concurrent in terms of reported variants.

@stale
Copy link

stale bot commented Aug 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 13, 2023
@stale stale bot removed the wontfix label Dec 11, 2023
@anngvu anngvu closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants