Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit jhu_ntap #1

Closed
9 tasks done
anngvu opened this issue Nov 9, 2022 · 6 comments
Closed
9 tasks done

Submit jhu_ntap #1

anngvu opened this issue Nov 9, 2022 · 6 comments
Assignees

Comments

@anngvu
Copy link

anngvu commented Nov 9, 2022

Before creating a PR to upstream, the following issues in validation results need to be resolved/clarified:

Notes:

  • (With pwd being the public folder), validation run using docker run --rm -v $(pwd):/datahub cbioportal/cbioportal:4.1.13 validateStudies.py -d /datahub -l mixed_nfosi_2022 -u http://cbioportal.org -html /datahub/mixed_nfosi_2022/html_report
  • Generate case lists:
GCL=path/to/directory/with/script
python2 $GCL/generate_case_lists.py -c $GCL/case_list_conf.txt -d case_lists -s . -i mixed_nfosi_2022 -o
  • Validate with suitable version of image - @anngvu
  • Config for public cBioPortal requires a different genome reference for maf - @jaybee84
  • Don't forget to generate case list -- minor issue - @anngvu
  • Either rename patient id to disambiguate from cell line from patient or remove the cell line data?

Other issues, i.e. these don't directly affect validation results but need to be resolved

  • Create mirror issue in cBioPortal/datahub
  • Should HTML validation file be kept in the folder or moved elsewhere?
  • Official citation for citation field?
  • What LICENSE file to use?
  • Lobby for adding Plexiform Neurofibroma. Doesn't affect validation since we're technically using "mixed" cancer type currently.
@allaway
Copy link

allaway commented Nov 9, 2022

License: CC0 is likely what DSP says, but @jaybee84 can present the options to JHU Biobank PI to confirm preference.
Citation: Should probably be the sci data manuscript for JHU Biobank.

@jaybee84
Copy link

Genome reference conversation is being tracked in the JIRA issue: https://sagebionetworks.jira.com/browse/WORKFLOWS-250

@anngvu anngvu self-assigned this Nov 17, 2022
@anngvu anngvu moved this to In Progress in NF-OSI Sprints Nov 17, 2022
@anngvu anngvu moved this from In Progress to Done in NF-OSI Sprints Nov 28, 2022
@jaybee84
Copy link

jaybee84 commented Dec 6, 2022

Official citation: https://www.nature.com/articles/s41597-020-0508-5

@jaybee84
Copy link

jaybee84 commented Dec 6, 2022

LICENSE : Creative Commons Attribution 4.0 International License
(as mentioned in the associated publication: https://www.nature.com/articles/s41597-020-0508-5#rightslink)

@allaway
Copy link

allaway commented Dec 6, 2022

I think that license refers to the publication, not the data, but maybe I am misunderstanding it?

@jaybee84
Copy link

jaybee84 commented Dec 6, 2022

My understanding is that the data released through the publication also falls under the same license as the article which says free to share, adapt, and build upon as long as you provide attribution to the author. Any component that has requirements that exceed the article's license needs user to reach out to the original group directly.

@anngvu anngvu moved this from Done to In Progress in NF-OSI Sprints Jan 19, 2023
@anngvu anngvu moved this from In Progress to Done in NF-OSI Sprints Jan 20, 2023
@anngvu anngvu closed this as completed Jun 19, 2023
@anngvu anngvu changed the title Dataset submission overview issue checklist Submit jhu_ntap Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants