Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jhu_ntap (Hirbe) datataset #2

Closed
6 tasks done
anngvu opened this issue Sep 12, 2023 · 2 comments
Closed
6 tasks done

Update jhu_ntap (Hirbe) datataset #2

anngvu opened this issue Sep 12, 2023 · 2 comments
Assignees

Comments

@anngvu
Copy link

anngvu commented Sep 12, 2023

Issue to track updating hirbe dataset previous submitted (#1). (Note: the curators assigned the directory name nst_nfosi_ntap, this dataset is referenced as jhu because that is easier for us to remember.)

Changelog / Notes

(most recent changes on top)

Checklist

  • Format and replace with files noted in changelog
  • Regenerate case list
    GCL=path/to/directory/with/script python2 $GCL/generate_case_lists.py -c $GCL/case_list_conf.txt -d case_lists -s . -i nst_nfosi_ntap -o
  • Validate with suitable version of images
    docker run --rm -v $(pwd):/datahub cbioportal/cbioportal:4.1.13 validateStudies.py -d /datahub -l nst_nfosi_ntap -u http://cbioportal.org -html /datahub/nst_nfosi_ntap/html_report
  • Get approval
  • Create mirror issue in cBioPortal/datahub (cBioPortal requirement): Update current study nst_nfosi_ntap with new samples, data cBioPortal/datahub#2034
  • Make PR that passes checks: Update nfosi jhu dataset cBioPortal/datahub#2035
@anngvu anngvu self-assigned this Sep 12, 2023
@anngvu anngvu moved this to Todo in NF-OSI Sprints Sep 12, 2023
@anngvu anngvu moved this from Todo to In Progress in NF-OSI Sprints Sep 22, 2023
@anngvu anngvu moved this from In Progress to Todo in NF-OSI Sprints Oct 31, 2023
@anngvu anngvu moved this from Todo to In Progress in NF-OSI Sprints Feb 12, 2024
@anngvu anngvu changed the title Update nfosi hirbe datataset Update jhu_ntap (Hirbe) datataset Mar 11, 2024
@anngvu
Copy link
Author

anngvu commented May 22, 2024

@jaybee84 Closing this, we can start watching the PR cBioPortal#2035.

@anngvu anngvu closed this as completed May 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in NF-OSI Sprints May 22, 2024
@jaybee84
Copy link

jaybee84 commented May 22, 2024

Just want to mention that this refers to the JHU Biobank dataset which is from Christine Pratilas's Lab in Hopkins. They collaborated with Dr. Angela Hirbe for data generation. So maybe calling it Pratilas dataset (instead of Hirbe dataset) would reduce confusion going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants